787456 - Activity picker shows app name instead entry point

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[alberto.pastor]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.89 Safari/537.1

Steps to reproduce:

Launch an activity with more than 1 app handling it, and one of them being an entry point


Actual results:

The shown name is the app instead the entry point


Expected results:

It should show the entry point

Comment 2

[Sam Foster [:sfoster] (he/him)]

There's a new getLocalizedName API that has support for entry_points. Homescreen implemented it in bug 1118946. Its async though, I'll have to see if that's going to work in this context.

Comment 3

[Sam Foster [:sfoster] (he/him)]

How do we expect this to work? The communications app manifest has the following: 

    "pick": {
      "filters": {
        "type": {
          "required": true,
          "value": ["webcontacts/contact","webcontacts/email",
                    "webcontacts/tel","webcontacts/select",
                    "text/vcard", "text/x-vcard", "text/directory"]
         }
       },
      "disposition": "inline",
      "href": "/contacts/index.html?pick",
      "returnValue": true

..so although the href ensures we end up at the right entry point, when the activity handler is registered, it is the Communications app doing the registering and we get no info about entry point or the 'Contacts' label we want to show in the picker. We could look up the href and try to match against the app's entry points I guess? 

To use the app.getLocalizedValue() call to get the entry_point's localized display name, we'll make the handling of the 'activity-choice' event async. Apart from tests, is that going to cause other issues?

Comment 4

[Sam Foster [:sfoster] (he/him)]

Alive, see comment #3. I guess this has been broken for a long time (forever), but as Mike points out in bug 1148669 its a bit confusing, and not a great user experience.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Francisco, I'm told we're trying to migrate away from entry_points. As comms is the only app using entry_points, that would also be a fix for this bug - at least within Gaia - I'm not sure how many 3rd party apps use them? This an old, old bug, which I'm happy to try and fix if there is a reasonable way to do so - and an appetite for it. If you think entry_points will go away soonish and don't think its worth the trouble, can you resolve wontfix?

Comment 6

[[:fabrice] Fabrice Desré]

It's absolutely not worth the effort to fix that bug. Much better to focus on getting rid of entry points in the comms app.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

I do agree with Fabrice here. Trying to use an async function in a sync path to show UI may cause another problems as well.