Prevent threadpane selection/messagepane content mismatches on folder/tab switches

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Folder and Message Lists
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 18.0
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird17 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.56 KB, patch
mconley
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 657342 [details] [diff] [review]
patch


the 'hide' is earlier in the flow here, perhaps that will make the tests pass..
Attachment #657342 - Flags: review?(mconley)
Hrm, nope, still hitting failures:

SUMMARY-UNEXPECTED-FAIL | test-tabs-simple.js | test-tabs-simple.js::test_open_message_b_in_tab
  EXCEPTION: Desired selection is: [undefined undefined] but actual selection is:  [undefined undefined]
    at: test-folder-display-helpers.js line 113
       testHelperModule.do_throw test-folder-display-helpers.js 113
       mark_failure logHelper.js 620
       assert_selected test-folder-display-helpers.js 1912
       assert_selected_and_displayed test-folder-display-helpers.js 2045
       test_open_message_b_in_tab test-tabs-simple.js 105
       Runner.wrapper frame.js 582
       Runner._runTestModule frame.js 652
       Runner.runTestModule frame.js 698
       Runner.runTestFile frame.js 531
       runTestFile frame.js 710
       Bridge._execFunction server.js 179
       Bridge.execFunction server.js 183

For future reference, you can test this locally by executing the following in your objdir:

make SOLO_TEST=folder-display/test-tabs-simple.js mozmill-one

and you can run the entire folder-display folder with:

make SOLO_TEST=folder-display mozmill-one
(Assignee)

Comment 3

5 years ago
Comment on attachment 657342 [details] [diff] [review]
patch


rats.  lousy tests.
Attachment #657342 - Flags: review?(mconley)
(Assignee)

Comment 4

5 years ago
Created attachment 657696 [details] [diff] [review]
patch


this passes tests.  lot of spent time (us both) due to simple undefined throws being caught/masked/not displayed, in tests and console.
Attachment #657342 - Attachment is obsolete: true
Attachment #657696 - Flags: review?(mconley)
(Assignee)

Comment 5

5 years ago
ping...
Pong - I'm here. Review queue is a bit long - I'll get to this soon!
Comment on attachment 657696 [details] [diff] [review]
patch

This looks right via inspection.

Thanks alta88!
Attachment #657696 - Flags: review?(mconley) → review+
(Assignee)

Comment 8

5 years ago
(In reply to Mike Conley (:mconley) from comment #6)
> Pong - I'm here. Review queue is a bit long - I'll get to this soon!

ah ok, don't mean to nag.  just hoping to close out my current bugs and get them into 17 before the (likely) ice age arrives.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/29d6d9143fad
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
(Assignee)

Comment 10

5 years ago
Comment on attachment 657696 [details] [diff] [review]
patch

[Approval Request Comment]
see bug 596234, comment 79.
Attachment #657696 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #657696 - Flags: approval-mozilla-aurora? → approval-comm-aurora?
Attachment #657696 - Flags: approval-comm-aurora? → approval-comm-aurora+
Checked in: https://hg.mozilla.org/releases/comm-aurora/rev/e6dbf65e63b8
status-thunderbird17: --- → fixed
You need to log in before you can comment on or make changes to this bug.