Closed Bug 787475 Opened 9 years ago Closed 9 years ago
Prevent threadpane selection/messagepane content mismatches on folder/tab switches
No description provided.
the 'hide' is earlier in the flow here, perhaps that will make the tests pass..
Hrm, nope, still hitting failures: SUMMARY-UNEXPECTED-FAIL | test-tabs-simple.js | test-tabs-simple.js::test_open_message_b_in_tab EXCEPTION: Desired selection is: [undefined undefined] but actual selection is: [undefined undefined] at: test-folder-display-helpers.js line 113 testHelperModule.do_throw test-folder-display-helpers.js 113 mark_failure logHelper.js 620 assert_selected test-folder-display-helpers.js 1912 assert_selected_and_displayed test-folder-display-helpers.js 2045 test_open_message_b_in_tab test-tabs-simple.js 105 Runner.wrapper frame.js 582 Runner._runTestModule frame.js 652 Runner.runTestModule frame.js 698 Runner.runTestFile frame.js 531 runTestFile frame.js 710 Bridge._execFunction server.js 179 Bridge.execFunction server.js 183 For future reference, you can test this locally by executing the following in your objdir: make SOLO_TEST=folder-display/test-tabs-simple.js mozmill-one and you can run the entire folder-display folder with: make SOLO_TEST=folder-display mozmill-one
Comment on attachment 657342 [details] [diff] [review] patch rats. lousy tests.
this passes tests. lot of spent time (us both) due to simple undefined throws being caught/masked/not displayed, in tests and console.
Pong - I'm here. Review queue is a bit long - I'll get to this soon!
Comment on attachment 657696 [details] [diff] [review] patch This looks right via inspection. Thanks alta88!
Attachment #657696 - Flags: review?(mconley) → review+
(In reply to Mike Conley (:mconley) from comment #6) > Pong - I'm here. Review queue is a bit long - I'll get to this soon! ah ok, don't mean to nag. just hoping to close out my current bugs and get them into 17 before the (likely) ice age arrives.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Comment on attachment 657696 [details] [diff] [review] patch [Approval Request Comment] see bug 596234, comment 79.
Attachment #657696 - Flags: approval-mozilla-aurora?
Attachment #657696 - Flags: approval-mozilla-aurora? → approval-comm-aurora?
Attachment #657696 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.