787537 - Events that span two or more days are shown incorrect in print output (only shown on first day and with wrong time)

Status: RESOLVED FIXED

Description

[Stefan Sitter [:ssitter]]

An event that spans two or more days (e.g. 2012-08-30 20:00 to 2012-09-02 12:00) is shown incorrect in "Monthly Grid" and "Weekly Planner" print output.

Actual results:
Event is only shown on 2012-08-30 as "20:00-12:00 Title". This is wrong.

Expected result:
Event should be shown on every day 08-30 to 09-02 and with correct start and end time for this day.

Comment 1

[Rene Matteau]

In our case, the printing (monthly view), a 3 days recurring all day event will print only on the first day as: "All Day-All Day Event name".

A fix would be appreciated. Thanks...

Comment 2

[Stefan Sitter [:ssitter]]

Created attachment 658971 [details] [diff] [review]
regression fix (print on all days)

Patch ensures that the event/task is printed on all days. I had to add some special treatment to cover all cases like end time < start time (e.g. 2012-08-30 20:00 to 2012-09-02 12:00) or to not include an additional day for all-day events.

Comment 3

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 658971 [details] [diff] [review]
regression fix (print on all days)

r=philipp, thanks for the patch!

Very minor nit, could you change:

+            if ( !itemStartDate && !itemEndDate ) {
to:

+            if (!itemStartDate && !itemEndDate) {

Comment 4

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/comm-central/rev/f181aef1ee3f

Comment 5

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/releases/comm-aurora/rev/042549694f27

Comment 6

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/releases/comm-beta/rev/c0e72119e5f7