Drop the Get from WebIDL attribute getters which satisfy certain conditions

RESOLVED FIXED in mozilla18

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla18
x86
Mac OS X
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In particular:

1)  Infallible
2)  Return type not nullable
3)  Return type not outparam.

we would typically write such things without the "Get" in C++, so we should do the same for WebIDL bindings.
Created attachment 657520 [details] [diff] [review]
Don't prefix WebIDL getters names with a Get if they look like simple member access on the C++ side.
Attachment #657520 - Flags: review?(peterv)
Assignee: nobody → bzbarsky
Whiteboard: [need review]
Attachment #657520 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/443937d07b13

I still need to update the docs.
Flags: in-testsuite-
Keywords: dev-doc-needed
Whiteboard: [need review]
Target Milestone: --- → mozilla18
Keywords: dev-doc-needed → dev-doc-complete
https://hg.mozilla.org/mozilla-central/rev/443937d07b13
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.