787570 - [Regression] Relative URLs do not function properly in Reader mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

1) Open Firefox
2) Go to http://en.m.wikipedia.org/wiki/IU_(singer) (Note: last paren probably won't auto-add)
3) Click the reader mode icon
4) Click the "Lost and Found" link (or any other link on the page).

Expected: You are taken to http://en.m.wikipedia.org/wiki/Lost_and_Found_(EP)
Actual: You are taken to http://en.m.wikipedia.org/wiki/Main_Page (you probably actually go to the base URL but are redirected here)

This bug was originally fixed in bug 776110 and has since regressed.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Fix relative URLs in reader mode

Regression from bug 779796. If the URI already begins with slash, there's no need to add another one.

Comment 2

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/abba691cf404

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 657527 [details] [diff] [review]
Fix relative URLs in reader mode

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 779796
User impact if declined: links/images won't work for some pages in reader mode
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Approved for uplift, assuming this lands on central without incident.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/abba691cf404

Comment 6

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-beta/rev/2bbf690626ab

Comment 7

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/3fcc163ce4bb

Comment 8

[Cristian Nicolae (:xti)]

I cannot reproduce this issue on the latest m-c, m-a and m-b builds. Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4