Closed
Bug 787570
Opened 13 years ago
Closed 13 years ago
[Regression] Relative URLs do not function properly in Reader mode
Categories
(Firefox for Android Graveyard :: Reader View, defect, P1)
Tracking
(firefox16 verified, firefox17 verified, firefox18 verified)
VERIFIED
FIXED
Firefox 18
People
(Reporter: mcomella, Assigned: bnicholson)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.12 KB,
patch
|
lucasr
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1) Open Firefox
2) Go to http://en.m.wikipedia.org/wiki/IU_(singer) (Note: last paren probably won't auto-add)
3) Click the reader mode icon
4) Click the "Lost and Found" link (or any other link on the page).
Expected: You are taken to http://en.m.wikipedia.org/wiki/Lost_and_Found_(EP)
Actual: You are taken to http://en.m.wikipedia.org/wiki/Main_Page (you probably actually go to the base URL but are redirected here)
This bug was originally fixed in bug 776110 and has since regressed.
Assignee | ||
Comment 1•13 years ago
|
||
Regression from bug 779796. If the URI already begins with slash, there's no need to add another one.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attachment #657527 -
Flags: review?(lucasr.at.mozilla)
Updated•13 years ago
|
Attachment #657527 -
Flags: review?(lucasr.at.mozilla) → review+
Updated•13 years ago
|
Priority: -- → P1
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 657527 [details] [diff] [review]
Fix relative URLs in reader mode
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 779796
User impact if declined: links/images won't work for some pages in reader mode
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none
Attachment #657527 -
Flags: approval-mozilla-beta?
Attachment #657527 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•13 years ago
|
status-firefox16:
--- → affected
status-firefox17:
--- → affected
Updated•13 years ago
|
Attachment #657527 -
Flags: approval-mozilla-beta?
Attachment #657527 -
Flags: approval-mozilla-beta+
Attachment #657527 -
Flags: approval-mozilla-aurora?
Attachment #657527 -
Flags: approval-mozilla-aurora+
Comment 4•13 years ago
|
||
Approved for uplift, assuming this lands on central without incident.
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Assignee | ||
Comment 6•13 years ago
|
||
Assignee | ||
Comment 7•13 years ago
|
||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
Comment 8•13 years ago
|
||
I cannot reproduce this issue on the latest m-c, m-a and m-b builds. Closing bug as verified fixed.
--
Device: Galaxy Note
OS: Android 4.0.4
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•