78759 - help viewer needs skin help

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Ian Oeschger (gone)]

Mozilla help has a Home button with no skin (so it doesn't currently display at
all in Modern) and an old print button. Plus the hover states aren't hooked up.
Marlon, are the right guy to get help from on this? Hope so.

Comment 1

[marlon bishop]

joe hewitt hooks things up

Comment 2

[Ian Oeschger (gone)]

Thanks, Marlon
I think I can hook it up (though some help there would be great, too). The thing
I don't have is any actual resources to use for the button. Like a Help icon. A
Home icon. That sort of thing.

Comment 3

[marlon bishop]

oh i see.. Is this a home button different from the home button we currently use 
in the navigator window?  i don't believe we have a help button.  Where do these 
buttons reside, in the primary toolbar?

Comment 4

[Ian Oeschger (gone)]

Hey, Marlon
Just wanted to see if you thought this was something you could get to in the
next couple of weeks. The Home button, in particular, which is currently
invisible in the help viewer because I have no GIFs associated with it.

Thanks a lot
Also let me know if you have any update on the help masthead.

Comment 5

[Ian Oeschger (gone)]

Rereading my own last comment: Hope I didn't sound presumptuous, Marlon. Not
even sure this is something you can get to at all, but if you have a second (or
a Home button GIF lying around :), that'd be great. Thanks again. -i

Comment 6

[marlon bishop]

thank you for withholding all presumptuousness ;)  i haven't forgotten about
this at all.  i have both those items on my agenda for post 0.9.1.  i will even
move them up on my list of priorities 
.m

Comment 7

[Ian Oeschger (gone)]

Marlon just handed over some GIFs for the Home button. Thanks, man. Looks good.
I will be integrating those in today and getting stuff together for a
review/check-in.

Reassigning to self.

Comment 8

[Ian Oeschger (gone)]

Attachment: adding home button icons, updating help.css

Comment 9

[Ian Oeschger (gone)]

Attachment: screenshot of help win with home and print buttons restored

Comment 10

[Ian Oeschger (gone)]

Screenshot in previous attachment shows Help window looking OK in new Modern
skin. Still needs its masthead, but the home button is up now, has its states,
and the print button I lost is restored.

Joe &/| German: do one of you think you could r=you the patch I put in here for
help.css and my changes to the jar.mn? I'll need to get an sr (blake, are you
here for this?), but a review would really speed this along. At issue: I put the
home icons in modernjar:communicator/skin, following joe's edict to put the help
stuff over in modern.jar rather than the help.jar itself. Is that an OK place
for those icons? Also, I stole the navigator.css print button styles, but I
didn't have the same parent-child stuff going on with menubutton-dual, so I just
stripped that out. Seems to work OK. Thanks a lot!

Comment 11

[Ian Oeschger (gone)]

Joe: When you get a second, do you think you can r=hewitt this small patch to
the help.cs? Without this update, there's no help button in modern (and only a
text-labelled button in classic), and so the Home button is invisible. Thanks

Comment 12

[Joe Hewitt (gone)]

sr=hewitt

Comment 13

[Ian Oeschger (gone)]

Marlon
Did you guys receive the help masthead? For a while we seemed to have a blank 
spot in the help viewer where the masthead would be, now no blank spot. Not sure 
if we should plan on having this in for .9.2 or not.

Thanks

Comment 14

[rudman]

Resetting target milestone for limbo additions.

Comment 15

[marlon bishop]

The help masthead image has been completed, and Joe should have it ready by now 
in his next batch of checkins.  Joe?

Comment 16

[Ian Oeschger (gone)]

Hey, if you are checking in skin updates, do you want to grab the updated 
help.css I have been waiting to check in anyway? (joe, I think you sr=hewitted 
it.) It just has the CSS to get the home button there and updated references to 
the print button icon. You probably need to make updates to that file to pick up 
the masthead anyway?

I will attach the whole CSS file here. Note the lameness: I stick the same 
help.css file in the modern and classic jars, and end up with a classic skin 
that looks very bad.

Comment 17

[Ian Oeschger (gone)]

Attachment: updates to help.css (whole file attached here)

Comment 18

[Joe Hewitt (gone)]

Just yesterday I did a little work on the CSS for help viewer to add the
masthead and the home icon.  I noticed that you were sharing that help.css
between modern and classic, which is not the best approach, so I split the files
up between classic and modern.  I also did a little extra polish work on the
modern and classic CSS.  Patch forthcoming...

Comment 19

[Joe Hewitt (gone)]

Attachment: patch part 1

Comment 20

[Joe Hewitt (gone)]

Attachment: classic help.css

Comment 21

[Joe Hewitt (gone)]

Attachment: modern help.css

Comment 22

[Joe Hewitt (gone)]

fixed on trunk and branch

Comment 23

[Brant Gurganus]

v