787606 - unable to access watcher.ini file from the sutagent

Status: RESOLVED FIXED

(Testing Graveyard :: SUTAgent, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in verify.py, we add a watcher.ini file.  This is done via copy to the sdcard, dd to the /data/data/com.mozilla.watcher.ini/files directory, then we read that file and verify it is accurate before calling it a success.

This all works on the panda board except for the read watcher.ini to verify it.

Comment 1

[Justin Wood (:Callek)]

would the execsu coming changes with SUTAgent1.13 work here on the panda?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

there might be a solution with that.

Comment 3

[William Lachance (:wlach)]

If the "push" works, it should return a hash of the file that we just pushed, which we can then check against the desired hash for the file. 

If you think about it, there's no need for anything else with regards to watcher.ini. :) There's no real harm in pushing the file when we don't need to, additional checks will only slow things down.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Actually we are pushing to the sdcard, then dd from there to the /data/data directory.

I did find that hash works on the file, just not our check to see if the file exists.  So we can easily modify the source to make this work!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: don't check if the file exists, just hash it (1.0)

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 658432 [details] [diff] [review]
don't check if the file exists, just hash it (1.0)

I'm not so sure your findings are accurate, to use one tegra currently failing this check:

[cltbld@foopy32 builds]$ PYTHONPATH=/builds/sut_tools python
Python 2.6.6 (r266:84292, Dec  7 2011, 20:48:22)
[GCC 4.4.6 20110731 (Red Hat 4.4.6-3)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from sut_lib import connect
>>> dm = connect("tegra-066")
reconnecting socket
>>> realLoc = "/data/data/com.mozilla.watcher/files/watcher.ini"
>>> dm.getRemoteHash(realLoc)
>>>
[cltbld@foopy32 builds]$ telnet tegra-066 20701
Trying 10.250.49.53...
Connected to tegra-066.
Escape character is '^]'.
$>exec ls /data/data/com.mozilla.watcher/files/watcher.ini
/data/data/com.mozilla.watcher/files/watcher.ini
return code [0]
$>exec ls /data/data/com.mozilla.watcher/files
watcher.ini
return code [0]
$>ls /data/data/com.mozilla.watcher/files
$>hash /data/data/com.mozilla.watcher/files/watcher.ini
##AGENT-WARNING## Couldn't calculate hash for file /data/data/com.mozilla.watcher/files/watcher.ini file not foun
d
$>

... so we can't hash the file if we can't see the file.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

This is what I see on my pandaboard:

jmaher@jmaher-MacBookPro:~/mozilla/tools/sut_tools$ telnet 192.168.1.77 20701
Trying 192.168.1.77...
Connected to 192.168.1.77.
Escape character is '^]'.
$>ls /data/data/org.mozilla.watcher 
files
$>ls /data/data/org.mozilla.watcher/files
watcher.ini
$>ls /data/data/org.mozilla.watcher/files/watcher.ini
##AGENT-WARNING## /data/data/org.mozilla.watcher/files/watcher.ini is not a directory
$>hash /data/data/org.mozilla.watcher/files/watcher.ini
b97bf386915ef8271b8470ed3f03a3b6
$>

but in my case this works:
$>exec ls /data/data/org.mozilla.watcher/files/watcher.ini
/data/data/org.mozilla.watcher/files/watcher.ini
return code [0]

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Callek, I believe we can close this bug as we have this working now, any objections?

Comment 9

[Geoff Brown [:gbrown]]

Sounds like this was fixed long ago.