Closed Bug 787627 Opened 8 years ago Closed 8 years ago
Wrong curve is used for XHDPI with hardware menu button
Previously, the right side of the tab button curve was vertically aligned with the right edge of the screen. Now, it looks like the "tail" version of the curve is being used, but it looks bad because it's cut off. Screenshot attached. Note the sliver of black space to the right of the curve.
Summary: Wrong curve is used for XHDPI without menu button → Wrong curve is used for XHDPI with hardware menu button
This patch fixes the curve. Ideally the calculations should use 0.5f, and not 0.48f. However the sizes don't follow math perfectly :( On phones: Size of full tabs button: 98 Size of curve: 48 * 1.125 = 54 From right, move half the curve for the tail = (98 - 54/2) = 71 Size of non-tailed tabs button: 72 71 != 72 :( On tablets: Size of full tabs button: 115 Size of the curve: 56 * 1.125 = 63 From right, move half the curve for the tail = (115 - 63/2) = 83.5 Size of non-tailed tabs button: 84 83.5 != 84 :( If Ian is happy to make everything fall in order, we can use 0.5f.
On phones: either full tabs button should be 99 or cropped tabs button should be 71 On tablets: size of cropped tabs button should be 83.5 (and that's going to hit sub-pixel anti-aliasing and android is going to get confused and.. oh my! :( )
Sriram - You have me confused. Should I review this patch, or is the rendering not good enough?
The rendering is good enough. But isn't perfect as per math ;) I am thinking of a different approach. Will post a newer patch.
The first patch was strict in math and hence we had few issues. Brian asked to try using the width specified for the button and just cut the curves on left and right (instead of being strict). This patch does that. The right cropped curve needs to be a bit inner. Hence one of the control point is at 5% inwards of the top right/left corner. Tested and working on all phones and tablets.
Attachment #659319 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
The Tabs Menu button shape was corrected on the latest Nightly. Closing bug as verified fixed on: Firefox 18.0a1 (2012-09-18) Device: Galaxy Note OS: Android 4.0.4
You need to log in before you can comment on or make changes to this bug.