The default bug view has changed. See this FAQ.

Zune and Royale have wrong window color with draw in title bar

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

({ux-consistency})

unspecified
Thunderbird 18.0
All
Windows XP
ux-consistency
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird17 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
From bug 755793 comment 49:

> Created attachment 657201 [details]
> mail.tabs.drawInTitlebar enabled with Zune Desktop Theme
> 
> Just wanted to note that drawing in titlebar causes unreadable visuals
> with the official Zune theme [1].
> 
> [1]: http://go.microsoft.com/fwlink/?LinkID=75078

It look I didn't used the official themes (there are a lot of them around). I haven't found a official DL link for Royale but the one I now used looks most "official".
(Assignee)

Comment 1

5 years ago
Created attachment 657553 [details] [diff] [review]
patch

Patch setting individual colors instead using the system colors which don't match the border colors.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #657553 - Flags: ui-review?(nisses.mail)
Attachment #657553 - Flags: review?(nisses.mail)
(Assignee)

Comment 2

5 years ago
Created attachment 657554 [details]
screenshot

Screenshot for easier UI-review. On top Zune active window, second with inactive window, third Royale activ and the last inactive.
Comment on attachment 657553 [details] [diff] [review]
patch

Looks good!
Attachment #657553 - Flags: ui-review?(nisses.mail)
Attachment #657553 - Flags: ui-review+
Attachment #657553 - Flags: review?(nisses.mail)
Attachment #657553 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Attachment #657553 - Attachment is patch: true
https://hg.mozilla.org/comm-central/rev/156e66fb3269
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
(Assignee)

Comment 5

5 years ago
Comment on attachment 657553 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 755793
User impact if declined: only visual, hard readable tabs
Risk to taking this patch (and alternatives if risky): no high risk, it's only color change through CSS.

If approval + I'll add a patch which applies cleanly.
Attachment #657553 - Flags: approval-comm-aurora?
(Assignee)

Comment 6

5 years ago
This patch applies on comm-aurora. So no need for a special patch.
Attachment #657553 - Flags: approval-comm-aurora? → approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/120aa51ba5d3
status-thunderbird17: --- → fixed
You need to log in before you can comment on or make changes to this bug.