Use pymake by default on Win64 builds

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: sid0, Assigned: coop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pymake][buildduty])

Attachments

(2 attachments)

Bug 595385 enables Pymake on Firefox Win32 builds. We should enable it on Win64 builds as well. There are still some issues to be resolved -- those should be marked blocking this.
(Reporter)

Updated

5 years ago
Priority: P2 → --
(Reporter)

Updated

5 years ago
Depends on: 787806

Comment 1

5 years ago
(In reply to Siddharth Agarwal [:sid0] from comment #0)
> Bug 595385 enables Pymake on Firefox Win32 builds. We should enable it on

That'd be bug 593585. :)
(Reporter)

Comment 2

5 years ago
Created attachment 657813 [details] [diff] [review]
go fast with pymake

Indeed it would!

Looks like bug 787806 is the only thing stopping us.
Attachment #657813 - Flags: review?(khuey)

Updated

5 years ago
Whiteboard: [pymake] → [pymake][buildduty]
(Reporter)

Comment 3

5 years ago
OK, bug 787806 is on mozilla-central and mozilla-inbound, and build-system (which already has win64 enabled) is green. This should be good to go now, though to be fast we'll need attachment 657813 [details] [diff] [review].
Assignee: nobody → coop
Status: NEW → ASSIGNED
Priority: -- → P2
Created attachment 658338 [details] [diff] [review]
Enables pymake on win64, and removes the exception for the build-system project branch
Attachment #658338 - Flags: review?(armenzg)

Updated

5 years ago
Attachment #658338 - Flags: review?(armenzg) → review+
Comment on attachment 658338 [details] [diff] [review]
Enables pymake on win64, and removes the exception for the build-system project branch

https://hg.mozilla.org/build/buildbot-configs/rev/beb4ed05620e
Attachment #658338 - Flags: checked-in+

Comment 6

5 years ago
Live in production.
Comment on attachment 657813 [details] [diff] [review]
go fast with pymake

sid0: are you still waiting on this review? I'm happy to rubber stamp it if so.
(Reporter)

Comment 8

5 years ago
Yeah, sure, that would be great.
Attachment #657813 - Flags: review?(khuey) → review+
(Reporter)

Comment 9

5 years ago
Comment on attachment 657813 [details] [diff] [review]
go fast with pymake

https://hg.mozilla.org/integration/mozilla-inbound/rev/85dea78cdb44
Attachment #657813 - Flags: checked-in+
https://hg.mozilla.org/mozilla-central/rev/85dea78cdb44
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.