Closed Bug 787655 Opened 7 years ago Closed 7 years ago

Use pymake by default on Win64 builds

Categories

(Release Engineering :: General, defect, P2)

All
Windows 7
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rain1, Assigned: coop)

References

Details

(Whiteboard: [pymake][buildduty])

Attachments

(2 files)

Bug 595385 enables Pymake on Firefox Win32 builds. We should enable it on Win64 builds as well. There are still some issues to be resolved -- those should be marked blocking this.
Priority: P2 → --
Depends on: 787806
(In reply to Siddharth Agarwal [:sid0] from comment #0)
> Bug 595385 enables Pymake on Firefox Win32 builds. We should enable it on

That'd be bug 593585. :)
Indeed it would!

Looks like bug 787806 is the only thing stopping us.
Attachment #657813 - Flags: review?(khuey)
Whiteboard: [pymake] → [pymake][buildduty]
OK, bug 787806 is on mozilla-central and mozilla-inbound, and build-system (which already has win64 enabled) is green. This should be good to go now, though to be fast we'll need attachment 657813 [details] [diff] [review].
Assignee: nobody → coop
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #658338 - Flags: review?(armenzg) → review+
Comment on attachment 658338 [details] [diff] [review]
Enables pymake on win64, and removes the exception for the build-system project branch

https://hg.mozilla.org/build/buildbot-configs/rev/beb4ed05620e
Attachment #658338 - Flags: checked-in+
Live in production.
Comment on attachment 657813 [details] [diff] [review]
go fast with pymake

sid0: are you still waiting on this review? I'm happy to rubber stamp it if so.
Yeah, sure, that would be great.
Attachment #657813 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/85dea78cdb44
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.