78766 - new leaks from style context changes

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron:]

The following new leaks seem to be the result of pierre's style context changes
this morning:

--NEW-LEAKS-----------------------------------leaks------leaks%-----------------------
nsLanguageAtom                                  164          -
nsStr                                           920     411.11%
AtomImpl                                         72      20.00%
TOTAL                                          1156

Also, I think the reason the bloat stats went down is that the replacement for
StyleContextData isn't being logged.

Comment 1

[David Baron :dbaron:]

Probably the root is the nsLanguageAtom leaks...

Comment 2

[karnaze (gone)]

Reassigning to attinasi and moving to m0.9.1.

Comment 3

[Marc Attinasi]

David, I think you are right. The static style contexts are not freeing thier 
languageAtoms until AFTER the leak collection is done. This will be fixed when 
bug 80084 is fixed, I'm very confident. Thanks for keeping us honest!

Comment 4

[karnaze (gone)]

dbaron, do you have any idea how big of a leak this is.

Comment 5

[Marc Attinasi]

This is a leak on shutdown, and the dependent bug 80084 has to be fixed to fix
this. IMO, it is not critical because it only leaks on shutdown. Moving to 0.9.2
like the dcependent bug.

Comment 6

[Marc Attinasi]

This will be moot when David lands his new style changes. Marking dependent and
assigning to him.

Comment 7

[David Hyatt]

fixed.

Comment 8

[Hixie (not reading bugmail)]

Rubber stamp verification.