Closed Bug 78766 Opened 21 years ago Closed 21 years ago

new leaks from style context changes

Categories

(Core :: CSS Parsing and Computation, defect)

x86
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: dbaron, Assigned: hyatt)

References

Details

(Keywords: memory-leak, Whiteboard: [tind-mlk])

The following new leaks seem to be the result of pierre's style context changes
this morning:

--NEW-LEAKS-----------------------------------leaks------leaks%-----------------------
nsLanguageAtom                                  164          -
nsStr                                           920     411.11%
AtomImpl                                         72      20.00%
TOTAL                                          1156

Also, I think the reason the bloat stats went down is that the replacement for
StyleContextData isn't being logged.
Keywords: mlk
Whiteboard: [tind-mlk]
Probably the root is the nsLanguageAtom leaks...
Reassigning to attinasi and moving to m0.9.1.
Assignee: pierre → attinasi
Target Milestone: --- → mozilla0.9.1
David, I think you are right. The static style contexts are not freeing thier 
languageAtoms until AFTER the leak collection is done. This will be fixed when 
bug 80084 is fixed, I'm very confident. Thanks for keeping us honest!
Status: NEW → ASSIGNED
Depends on: 80084
dbaron, do you have any idea how big of a leak this is.
This is a leak on shutdown, and the dependent bug 80084 has to be fixed to fix
this. IMO, it is not critical because it only leaks on shutdown. Moving to 0.9.2
like the dcependent bug.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Assignee: attinasi → hyatt
Status: ASSIGNED → NEW
Depends on: 78695
This will be moot when David lands his new style changes. Marking dependent and
assigning to him.
Status: NEW → ASSIGNED
fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Rubber stamp verification.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.