787668 - Use |use parent| instead of |use base|

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Once bug 787529 is checked in, all Bugzilla modules will be able to use |use parent| instead of |use base|, see http://perldoc.perl.org/5.10.1/parent.html.

Note that for modules which have |use fields|, we must still use |use base|.

Comment 1

[Matt Selsky [:selsky]]

Attachment: v1

Switch to "use parent" except where "use fields" follows.  Also update 010dependencies.t to look for "use base", "use parent", or "use parent -norequires"

Comment 2

[Frédéric Buclin]

Comment on attachment 677663 [details] [diff] [review]
v1

This looks good and basic testing shows nothing wrong. r=LpSolit

Comment 3

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/                                        
modified mod_perl.pl
modified Bugzilla/Attachment.pm                                                                                     
modified Bugzilla/Bug.pm
modified Bugzilla/BugUrl.pm
modified Bugzilla/CGI.pm
modified Bugzilla/Classification.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Component.pm
modified Bugzilla/Config.pm
modified Bugzilla/Constants.pm
modified Bugzilla/DB.pm
modified Bugzilla/Error.pm
modified Bugzilla/Extension.pm
modified Bugzilla/Field.pm
modified Bugzilla/Flag.pm
modified Bugzilla/FlagType.pm
modified Bugzilla/Group.pm
modified Bugzilla/JobQueue.pm
modified Bugzilla/Keyword.pm
modified Bugzilla/Mailer.pm
modified Bugzilla/Milestone.pm
modified Bugzilla/Product.pm
modified Bugzilla/RNG.pm
modified Bugzilla/Report.pm
modified Bugzilla/Search.pm
modified Bugzilla/Status.pm
modified Bugzilla/Template.pm
modified Bugzilla/Token.pm
modified Bugzilla/User.pm
modified Bugzilla/UserAgent.pm
modified Bugzilla/Util.pm
modified Bugzilla/Version.pm
modified Bugzilla/Whine.pm
modified Bugzilla/Auth/Login/CGI.pm
modified Bugzilla/Auth/Login/Cookie.pm
modified Bugzilla/Auth/Login/Env.pm                                                                                 
modified Bugzilla/Auth/Verify/DB.pm
modified Bugzilla/Auth/Verify/RADIUS.pm
modified Bugzilla/BugUrl/Bugzilla.pm
modified Bugzilla/BugUrl/Debian.pm
modified Bugzilla/BugUrl/GitHub.pm
modified Bugzilla/BugUrl/Google.pm
modified Bugzilla/BugUrl/JIRA.pm
modified Bugzilla/BugUrl/Launchpad.pm
modified Bugzilla/BugUrl/MantisBT.pm
modified Bugzilla/BugUrl/SourceForge.pm
modified Bugzilla/BugUrl/Trac.pm
modified Bugzilla/BugUrl/Bugzilla/Local.pm
modified Bugzilla/Config/Common.pm
modified Bugzilla/DB/Mysql.pm
modified Bugzilla/DB/Oracle.pm
modified Bugzilla/DB/Pg.pm
modified Bugzilla/DB/Sqlite.pm
modified Bugzilla/DB/Schema/Mysql.pm
modified Bugzilla/DB/Schema/Oracle.pm
modified Bugzilla/DB/Schema/Pg.pm
modified Bugzilla/DB/Schema/Sqlite.pm
modified Bugzilla/Field/Choice.pm
modified Bugzilla/Install/CPAN.pm
modified Bugzilla/Install/Filesystem.pm
modified Bugzilla/Install/Localconfig.pm
modified Bugzilla/Install/Requirements.pm
modified Bugzilla/Install/Util.pm
modified Bugzilla/Job/Mailer.pm
modified Bugzilla/JobQueue/Runner.pm
modified Bugzilla/Migrate/Gnats.pm
modified Bugzilla/Search/Condition.pm
modified Bugzilla/Search/Quicksearch.pm
modified Bugzilla/Search/Recent.pm
modified Bugzilla/Search/Saved.pm
modified Bugzilla/Send/Sendmail.pm
modified Bugzilla/Template/Context.pm
modified Bugzilla/Template/Plugin/Bugzilla.pm
modified Bugzilla/Template/Plugin/Hook.pm
modified Bugzilla/User/Setting.pm
modified Bugzilla/User/Setting/Lang.pm
modified Bugzilla/User/Setting/Skin.pm
modified Bugzilla/User/Setting/Timezone.pm
modified Bugzilla/WebService/Bug.pm
modified Bugzilla/WebService/Bugzilla.pm
modified Bugzilla/WebService/Classification.pm
modified Bugzilla/WebService/Constants.pm
modified Bugzilla/WebService/Group.pm
modified Bugzilla/WebService/Product.pm
modified Bugzilla/WebService/README
modified Bugzilla/WebService/User.pm
modified Bugzilla/WebService/Util.pm
modified Bugzilla/WebService/Server/XMLRPC.pm
modified Bugzilla/Whine/Query.pm
modified Bugzilla/Whine/Schedule.pm
modified contrib/extension-convert.pl
modified docs/lib/Pod/Simple/HTML/Bugzilla.pm
modified docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm
modified extensions/BmpConvert/Extension.pm
modified extensions/Example/Extension.pm
modified extensions/Example/lib/WebService.pm
modified extensions/Example/lib/Auth/Login.pm
modified extensions/Example/lib/Auth/Verify.pm
modified extensions/MoreBugUrl/Extension.pm
modified extensions/MoreBugUrl/lib/GetSatisfaction.pm
modified extensions/MoreBugUrl/lib/PHP.pm
modified extensions/MoreBugUrl/lib/RT.pm
modified extensions/MoreBugUrl/lib/ReviewBoard.pm
modified extensions/MoreBugUrl/lib/Rietveld.pm
modified extensions/OldBugMove/Extension.pm
modified extensions/Voting/Extension.pm
modified t/010dependencies.t
modified t/Support/Templates.pm
modified template/en/default/extensions/extension.pm.tmpl
modified template/en/default/extensions/util.pm.tmpl
modified xt/lib/Bugzilla/Test/Search/AndTest.pm
modified xt/lib/Bugzilla/Test/Search/Constants.pm
modified xt/lib/Bugzilla/Test/Search/CustomTest.pm
modified xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
modified xt/lib/Bugzilla/Test/Search/InjectionTest.pm
modified xt/lib/Bugzilla/Test/Search/NotTest.pm
modified xt/lib/Bugzilla/Test/Search/OrTest.pm
Committed revision 8499.

Comment 4

[Frédéric Buclin]

I had to add -norequire into Bugzilla/DB/Oracle.pm, else checksetup.pl failed:

There was an error connecting to Oracle:

 'Oracle' is not a valid choice for $db_driver in localconfig: Can't locate DBI/st.pm in @INC


Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/DB/Oracle.pm
Committed revision 8510.

Comment 5

[Frédéric Buclin]

There was a new file in 5.0 which missed this transition:

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Search/ClauseGroup.pm
Committed revision 8551.

Comment 6

[Frédéric Buclin]

Added to relnotes for 5.0rc1.