Closed Bug 787675 Opened 10 years ago Closed 10 years ago

Trigger jemalloc release assertions from within a new stack frame

Categories

(Core :: Memory Allocator, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

Right now, jemalloc assertions are hard to decipher in crashstats.  A failed assertion crashes within the stack frame which invokes ASSERT, and presumably because of compiler optimizations, our crashstats often are not able to tell us exactly which assert failed.

Anyway, I think we can fix this by crashing within a new stack frame.  Patch in a moment.
Attached patch Patch, v1Splinter Review
Attachment #657570 - Flags: review?(mh+mozilla)
Assignee: nobody → justin.lebar+bug
Comment on attachment 657570 [details] [diff] [review]
Patch, v1

Review of attachment 657570 [details] [diff] [review]:
-----------------------------------------------------------------

I think this should be done for MOZ_CRASH in a more general way, but that's ok to do it here for now (a related bug is bug 697301).
Attachment #657570 - Flags: review?(mh+mozilla) → review+
> I think this should be done for MOZ_CRASH in a more general way

Hm, yeah, I agree.  Although I wonder if there are cases where MOZ_CRASH is used and they don't want an extra stack frame (e.g. because that might overflow the stack)?
I filed bug 788069 on the general MOZ_CRASH case, although it's more complicated than I expected...
https://hg.mozilla.org/mozilla-central/rev/d155eefe75f3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.