Closed Bug 78770 Opened 23 years ago Closed 23 years ago

encapsulate printf's in BasicTableLayoutStrategy.cpp

Categories

(Core :: Layout: Tables, defect, P3)

Product:
Core
Component:
Layout: Tables
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.2

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

References

(
URL
)

Details

Attachments

(1 file)

patch
5.06 KB, patch
Details | Diff | Splinter Review 
we could significantly better encapsulate the printf's in 
BasicTableLayoutStrategy.cpp by using an #ifdef mechanism instead of global's. 
This would help with bug 78674.
Attached patch patch — — Splinter Review 

    
  
Blocks: 78674
Keywords: patch

    
    

    
  
Bernd, the change looks good to me. As long as Chris approves, I'll gladly give
my sr=attinasi

    
    

    
  
r=karnaze
Target Milestone: --- → mozilla0.9.1

    
    

    
  
looks like this should get checked-in in the next couple of days
for wait for the next milestone.   moving non-critical items off
the 0.9.1 list.

    
  
Target Milestone: mozilla0.9.1 → ---

    
    

    
  
0.9.2 since that's what the bug this blocks is set to.
Priority: -- → P3
Target Milestone: --- → mozilla0.9.2

    
    

    
  
fix checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
 Marking Verified
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: