787791 - [Events] When in 'current and future' mode the same events get loaded twice as user scrolls down

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[William Quiviger [:williamq]]

Attachment: this is a screenshot of the list of events

When scrolling down events and reaching the bottom, new events are added but they are no longer in chronological order (see attachment).

Comment 1

[Giorgos Logiotatidis [:giorgos]]

True, I 'll work on a patch asap and push to prod.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/78ef9759e2c2a4f617755e33e01e655694fa7636
[fix bug 787791] Do not load events twice.

Comment 3

[Ben (:bensternthal)]

Looks ok on stague.

Comment 4

[Galaxy Kadiyala [:Galaxy]]

Attachment: Selection_011.png

Screen of events.

Comment 5

[Galaxy Kadiyala [:Galaxy]]

I still see the duplicates issue is not yet resolved.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

Galaxy, 

I can't reproduce that. Can you please provide a url?

Comment 7

[Galaxy Kadiyala [:Galaxy]]

Here it is:

https://reps.mozilla.org/events/#/period/future/search/india/

Comment 8

[Galaxy Kadiyala [:Galaxy]]

Hi Giorgos,

I was just trying to search reps from India in list view and I see the same list is being populated thrice as I scroll down the page.

https://reps.mozilla.org/people/#/view/list/search/india/

Comment 9

[Giorgos Logiotatidis [:giorgos]]

I'm looking at this right now.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/d06d16ef5d84583bf673dfca5851b199747435e6
[fix bug 787791] Stop making API calls when full list gets loaded.

Tastypie upgrade (8757ea5) changed the API behavior when it comes to
'limit' meta data returned to API call. It's now limited to 1000, while
previously respected any limit given. We based parts of our logic on the
limit returned and that caused Events and Reps to be loaded multiple
times by consecutive API calls.

We fix that by watching the meta.next variable which always tells the
truth about the existence of more data, independently of the value of
the limit.

https://github.com/mozilla/remo/commit/aadbe6fc942ef854caed1ce20cc26b37d32d8731
Merge pull request #699 from glogiotatidis/787791

[fix bug 787791] Stop making API calls when full list gets loaded.

Comment 11

[John Giannelos [:nemo-yiannis]]

Tested it locally and it worked. On stage we don't have sufficient entries to verify that.
Using a breakpoint, it seems that the if condition changed works as expected.