787942 - Please add some id's or class arguments to elements in the login area

Status: VERIFIED FIXED

(support.mozilla.org :: Code Quality, task)

Description

[Florin Strugariu [:Bebe]]

Hi all

We are fixing the selenium tests (https://github.com/mozilla/sumo-tests) to match the new design and have some issues with the locators.

Can you guys add some id's or class arguments for the header login area please.

Here are the locators that we previously used: https://github.com/mozilla/sumo-tests/blob/master/pages/desktop/base.py#L34

And now the could look like: #aux-nav > ul > li:nth-of-type(2) > a but it's not reliable

also how should we contact you if we have more issues of this kind submit bugs, email, irc? 

Thanks,

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Can you list out which specific elements need easier selector access?

I assume:
* login
* register
* logout

Any others?

Can the selector be something like `#aux-nav li.login a`?

Comment 2

[Zac C (:zac)]

Hey ricky, it's most useful to have IDs or classes at the major user interaction points. Most of the main page have class or id already except where it;s a dynamic list so they're ok.

Just ask a question, login, register, logout, the logged in dropdown list <ul> element.

Locale picker already has a class so that's OK.

It helps in case the order or a new item is added we still get the correct one which wouldn't happen if we pick by nth/index.

Also the search in the header and the search on the homepage have the same name ('q').

Thanks heaps

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

I'll just be adding some classes. 1pt

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Just landed in prod:

https://github.com/mozilla/kitsune/commit/f044e9162c56550f43f33c8b59f605fcf45f373f

Comment 5

[Florin Strugariu [:Bebe]]

hey ricky I need one more class in that area.

I made a pull request for it hope it's ok.

https://github.com/mozilla/kitsune/pull/821

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks like the pulls are merged, and we have what we need to continue refining automation, for now.

Verified FIXED; thanks for filing this, Bebe!