bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Please add some id's or class arguments to elements in the login area

VERIFIED FIXED

Status

support.mozilla.org
Code Quality
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Bebe, Assigned: rrosario)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=dev c=general p=1, URL)

(Reporter)

Description

6 years ago
Hi all

We are fixing the selenium tests (https://github.com/mozilla/sumo-tests) to match the new design and have some issues with the locators.

Can you guys add some id's or class arguments for the header login area please.

Here are the locators that we previously used: https://github.com/mozilla/sumo-tests/blob/master/pages/desktop/base.py#L34

And now the could look like: #aux-nav > ul > li:nth-of-type(2) > a but it's not reliable

also how should we contact you if we have more issues of this kind submit bugs, email, irc? 

Thanks,
(Assignee)

Updated

6 years ago
Whiteboard: u=dev c=general p=
(Assignee)

Comment 1

6 years ago
Can you list out which specific elements need easier selector access?

I assume:
* login
* register
* logout

Any others?

Can the selector be something like `#aux-nav li.login a`?
OS: Linux → All
Hardware: x86_64 → All

Comment 2

6 years ago
Hey ricky, it's most useful to have IDs or classes at the major user interaction points. Most of the main page have class or id already except where it;s a dynamic list so they're ok.

Just ask a question, login, register, logout, the logged in dropdown list <ul> element.

Locale picker already has a class so that's OK.

It helps in case the order or a new item is added we still get the correct one which wouldn't happen if we pick by nth/index.

Also the search in the header and the search on the homepage have the same name ('q').

Thanks heaps
(Assignee)

Comment 3

6 years ago
I'll just be adding some classes. 1pt
Whiteboard: u=dev c=general p= → u=dev c=general p=1
(Assignee)

Comment 4

6 years ago
Just landed in prod:

https://github.com/mozilla/kitsune/commit/f044e9162c56550f43f33c8b59f605fcf45f373f
Assignee: nobody → rrosario
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

6 years ago
hey ricky I need one more class in that area.

I made a pull request for it hope it's ok.

https://github.com/mozilla/kitsune/pull/821
Looks like the pulls are merged, and we have what we need to continue refining automation, for now.

Verified FIXED; thanks for filing this, Bebe!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.