787988 - "Error: 0" reported when opening preference dialog (leftover debug statement?)

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Stefan Sitter [:ssitter]]

Thunderbird 16.0b1, Earlybird 17.0a2, Daily 18.0a1

Opening the preference dialog, advanced panel will throw the following error in Error Console:

> Error: 0
> Source file: chrome://messenger/content/preferences/advanced.js Line: 237

This looks like a leftover debug statement
> http://mxr.mozilla.org/comm-beta/source/mail/components/preferences/advanced.js#240

The error message is confusing and should be removed. Or it should be downgraded to an informational message with useful content if a debug message is required.

Comment 1

[Magnus Melin [:mkmelin]]

From bug 758326

Comment 2

[:aceman]

Nice, I can remove it.

Comment 3

[:aceman]

Attachment: patch

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/49a9b1d1e8be

Comment 5

[Kent James (:rkent)]

Comment on attachment 658173 [details] [diff] [review]
patch

[Approval Request Comment]

User impact if declined: Meaningless error message appears
Testing completed (on c-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): None

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/8cb5a4080073