78800 - Eliminate MacCVSLib from the mac build system

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Simon Fraser [no longer active]]

We can get rid of the MacCVS apple events glue library that is MacCVSLib; there 
are better ways to do this now.

This should avoid the annoying 'Please find MacCVS Pro' dialogs that you get 
sometimes when you change MacCVS Pro versions.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Version of MacCVS.pm that uses AppleEvents:Simple

Comment 2

[Scott Collins]

You may want to put the Mozilla Public License header in there.  Other than
that, it looks good.  Do you desire sr?

Comment 3

[Peter Van der Beken [:peterv]]

r=peterv.
Had just nearly finished this myself :-(. One issue I tried to solve, which I
couldn't with MacCVS Pro is selecting the right session when multiple sessions
with the same name are open. MacCVS Pro doesn't expose the path name of the
session file. The obvious solution to this problem is of course giving all your
session files different names.
Oh, and I think we could simplify this file a bit, but I'll leave that for the
future.

Comment 4

[Simon Fraser [no longer active]]

Ooops, sorry to step on your toes. How similar was your implementation?

Comment 5

[Peter Van der Beken [:peterv]]

Hey, no problem :-). It was eerily similar, I just tried to get rid of the new()
stuff. Seemed to me a checkout($sessionfile, $module, $revision, $date) would be
enough.

Comment 6

[Simon Fraser [no longer active]]

The new() stuff is OO Perl, making the session object self-contained, which I 
quite like.

Comment 7

[Peter Van der Beken]

I don't see the benefits of OO here, but let's just get this in and get rid of
the MacCVSLib. One nit: in |use vars qw($VERSION @ISA @EXPORT $MacCVSLib);| you
can now remove $MacCVSLib.

Comment 8

[rubydoo123]

9.3

Comment 9

[Simon Fraser [no longer active]]

Checked in.

Comment 10

[Jon Granrose]

QA to jj for verification.

Comment 11

[J.J. Enser]

verified