CertViewer: sizing problems

VERIFIED FIXED in psm2.0

Status

Core Graveyard
Security: UI
VERIFIED FIXED
17 years ago
a year ago

People

(Reporter: Bob Lord, Assigned: Javier Delgadillo)

Tracking

1.0 Branch
psm2.0
x86
Windows 2000
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Reporter)

Description

17 years ago
There are several sizing problems with the CertViewer.  These problems inlclude:

-The window expands to fit the widest field in the General pane (usually the
Subject Name).  That's almost always way too large.

-The window is not resizable
(Reporter)

Updated

17 years ago
Target Milestone: --- → 2.0
(Assignee)

Updated

17 years ago
Keywords: mozilla0.9.1
(Assignee)

Comment 1

17 years ago
Created attachment 35918 [details] [diff] [review]
Patch to fix bug.
(Assignee)

Comment 2

17 years ago
thayes, ddrinan: one of you please review.

Comment 3

17 years ago
r=mcgreer with a caveat on the unneccessary string copy
(Assignee)

Updated

17 years ago
Blocks: 78399, 78836
(Assignee)

Comment 4

17 years ago
Created attachment 35997 [details] [diff] [review]
Patch v2 with mcgreers comments incorporated
(Assignee)

Comment 5

17 years ago
Asking blizzard for super review
+  if (redraw) {
+    rowsToDelete = 0-CountNumberOfVisibleRows(mASN1Object);
+  }

That looks odd.  Can you comment that please?

+  nsXPIDLString temp;
+  CERTRDN **lastRdn;
+  lastRdn = rdns;
+  /* find last RDN */
+  lastRdn = rdns;
+  while (*lastRdn) lastRdn++;
+  lastRdn--;

Can you throw some vertical whitespace in there in between the variable
declarations and the actual code?  Stealth code!  And comment the while()
lasRdn-- magic please?

Other than that sr=blizzard
(Assignee)

Comment 7

17 years ago
I've made the modifications requested by blizzard and am sending this bug to
drivers@mozilla.org for check-in approval.
There are a lot of cases where inline style appears to be used for formatting. 
In almost every case there are classes in the skin that give the precise amount 
of padding and margin appropriate for specific uses. 

I'd like to see a screenshot of the effect of these patches. It seems there's a 
bunch of other UI details that need to be seen to. Mostly, these details are 
small alignment fixes and a matter of using the right class in the right 
situation. I'd be happy to perform a thorough examination of this chrome over 
the phone, and make recommendations as to what changes need to be made to make 
things fit, size, and align, as they should. Please let me know if you're 
interested. 
(Assignee)

Comment 9

17 years ago
Created attachment 36067 [details] [diff] [review]
Patch after incorporating ben's comments
(Assignee)

Comment 10

17 years ago
Created attachment 36068 [details]
Details panel w/ latest patch.
(s)r=ben@netscape.com for the latest set of changes. 
(Assignee)

Comment 12

17 years ago
Created attachment 36069 [details]
General panel after patch.
a=blizzard for 0.9.1
(Assignee)

Comment 14

17 years ago
fix has been checked in. (a=blizzard)
(Assignee)

Comment 15

17 years ago
Mark fixed for real this time.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 16

17 years ago
Verified fixed.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.0 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.