Proxy is not a function (typeof Proxy should be 'function')

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: David Bruant, Assigned: jorendorff)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {dev-doc-complete, site-compat})

18 Branch
mozilla25
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:p2])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Additionally to typeof, "Proxy" should be callable and do the same thing as "new Proxy"
(Reporter)

Updated

5 years ago
Blocks: 703537
Whiteboard: [js:p2]
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Updated

5 years ago
Assignee: general → jorendorff
Summary: typeof Proxy === 'object' (it should be 'function') → Proxy is not a function (typeof Proxy should be 'function')
(Assignee)

Comment 1

5 years ago
Created attachment 685134 [details] [diff] [review]
v1

The spec is vague at present but this seems clearly what's intended.

With this patch, Proxy(...) behaves exactly like new Proxy(...).

I thought it should get at least a little test coverage, so in addition to the obvious tests I also did s/new Proxy/Proxy/g on jit-test/tests/proxytest*1.js, arbitrarily switching a few existing tests to the new syntax.
Attachment #685134 - Flags: review?(ejpbruel)
(Assignee)

Comment 2

5 years ago
Review ping! (I know, king of hypocrites here)
Comment on attachment 685134 [details] [diff] [review]
v1

Review of attachment 685134 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good Jason! No comments.

I do have a question though: what exactly are cached protos?
Attachment #685134 - Flags: review?(ejpbruel) → review+
Blocks: 694100
We should get this rebased and landed.
Created attachment 757415 [details] [diff] [review]
rebased patch

I have rebased the old patch. Should be good to land now!
Attachment #685134 - Attachment is obsolete: true
Attachment #757415 - Flags: review?(ejpbruel)
Comment on attachment 757415 [details] [diff] [review]
rebased patch

Review of attachment 757415 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this patch was rebased, but never landed, probably because it was flagged for review. In general, I don't think its necessary to review a patch again if its a simple rebase.
Attachment #757415 - Flags: review?(ejpbruel) → review+
Created attachment 770225 [details] [diff] [review]
rebased again

Rebased the patch once again.
Attachment #757415 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/09dcdc2b2120
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/09dcdc2b2120
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Depends on: 892714
Added: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Keywords: dev-doc-complete, site-compat

Updated

4 years ago
Depends on: 899399
Depends on: 905947
No longer depends on: 905947
You need to log in before you can comment on or make changes to this bug.