788222 - Rename PNK_RB and friends

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

PNK_LB -> PNK_ELEM
PNK_LP -> PNK_CALL
PNK_RB -> PNK_ARRAY
PNK_RC -> PNK_OBJECT
PNK_RP -> (gone)

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 658167 [details] [diff] [review]
v1

Review of attachment 658167 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/Parser.cpp
@@ +4068,5 @@
>       * The four options here are:
>       * - PNK_VAR:   We're parsing var declarations.
>       * - PNK_CONST: We're parsing const declarations.
>       * - PNK_LET:   We are parsing a let declaration.
> +     * - PNK_CALL:  We are parsing the head of a let block.

Egad.  PNK_LP at least didn't give the wrong impression here, because the name was so crazy.  Now, this is just insane.  Could you file a followup to change at least this one case to not use PNK_LP somehow?  PNK_LETBLOCK seems like what should really happen here.

Comment 3

[Jason Orendorff [:jorendorff]]

Er, good point. Sorry about that.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c2e5feedaa8f