78825 - hang if you close mozilla when offline (empty trash on exit = ON)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P1)

Description

[grylchan]

BuildID:    2001050304

If you have a IMAP mail account, select the preference "empty trash on
exit", go offline, and exit messenger; the result is
it appears mozilla has quit, but the process is still runnning in the
background.

Reproducible: Always
Steps to Reproduce:
1.Log In into IMAP server (don't think the deletion model matters)
2.Go into Mail/News Account Settings
3.Select your account and then click server settings
4.Click on "empty trash on exit" preference and click ok
5.Go offline (either by clicking offline icon or from the File menu)
6. Exit Mozilla

Actual Results:  Mozilla appears to quit. But if run Task Manager (on Win NT), 
you will see the process still running

Expected Results:  Mozilla quits and if you won't see the process in Task 
Manager (on Win NT)

It hangs but it's not a visual Hang like it was with
"Clean up inbox on exit" bug 76687. It 'looks' like
it quits but it is really running in the background.

Haven't tried any of the linux or mac builds.

Comment 1

[scottputterman]

marking nsbeta1+

Comment 2

[David :Bienvenu]

Attachment: proposed fix

Comment 3

[David :Bienvenu]

CC'ing Navin and Seth for review - trivial fix to return error code. We won't
get into the code that removes sub-folders, but that's not likely to work if
deleting messages didn't work.

Comment 4

[Navin Gupta]

r=naving. 

Comment 5

[(not reading, please use [e-mail] instead)]

as hwaara pointed out to me,

why not "if (NS_FAILED(rv)) return rv;"

Comment 6

[David :Bienvenu]

well, they're the same in the end. But I change it.

Comment 7

[(not reading, please use [e-mail] instead)]

blizzard, isn't this the bug that was making your life hell?

Comment 8

[David :Bienvenu]

fix checked in.

Comment 9

[Christopher Blizzard (:blizzard)]

I don't use offline mode so no, it hasn't been a big deal to me.  Sounds nasty,
though.

Comment 10

[(not reading, please use [e-mail] instead)]

bliz:  I was thinking of your "hang on exit" bug with imap.

Comment 11

[grylchan]

using 2001052404 build on NT 4.0, 2001052308 build on Linux 2.2, and
2001052408 on Mac OS 9.0.4, I have verified this works.

Loggin into a IMAP server, Setting the pref "Empty trash on exit", 
going offline, then quiting Mozilla does not result in a hang/crash/
process running in background.

Marking as verified.