If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Consolidate jar creation boilerplate into a generic makefile rule

NEW
Unassigned

Status

()

Firefox for Android
General
P3
normal
5 years ago
4 years ago

People

(Reporter: cpeterson, Unassigned)

Tracking

17 Branch
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
This bug is forked from bug 777591 comment 9:


Review of attachment 657022 [details] [diff] [review] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/Makefile.in
@@ +1079,5 @@
> +	$(NSINSTALL) -D classes/gecko-mozglue
> +	$(JAVAC) $(JAVAC_FLAGS) -Xlint:all -d classes/gecko-mozglue $(addprefix $(srcdir)/,$(MOZGLUE_JAVA_FILES))
> +	jar cMf jars/gecko-mozglue.jar -C classes/gecko-mozglue .
> +
> +jars/gecko-util.jar: $(addprefix $(srcdir)/,$(UTIL_JAVA_FILES)) jars

you can probably have a generic rule for creating jars here, like:

SUB_JARS=jars/gecko-mozglue.jar jars/gecko-util.jar
PER_JAR_SOURCE_FILES=$(MOZGLUE_JAVA_FILES) $(UTIL_JAVA_FILES)

$(SUB_JARS): $(addprefix $(srcdir)/,$(PER_JAR_SOURCE_FILES)) jars
(Reporter)

Updated

4 years ago
Assignee: cpeterson → nobody
You need to log in before you can comment on or make changes to this bug.