Offline download selected and download flagged messages broken

VERIFIED FIXED

Status

VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
The checkin for the offline UI broke download selected and download flagged
messages, which were both finished and working fine before. I'm not sure why,
but MsgDownloadSelected and MsgDownloadFlagged were redefined incorrectly in
commandglue.js, after already being defined correctly in mailWindowOverlay.js.
I'm not sure what was going on - perhaps there's some confusion about how
GetSelectedMessages For Offline Use is supposed to work. All it does it download
the selected messages for offline use. GetFlaggedMessages works similarly. I'll
back out the broken code.
(Assignee)

Comment 1

18 years ago
Created attachment 33134 [details] [diff] [review]
the fix
(Assignee)

Comment 2

18 years ago
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Keywords: regression
Resolution: --- → FIXED

Updated

18 years ago
Blocks: 69070

Updated

18 years ago
No longer blocks: 69070

Updated

18 years ago
QA Contact: esther → gchan

Comment 3

18 years ago
adding lrg to Cc. Please verify for gchan.

Comment 4

18 years ago
Verified in Windows with 2001060408 build
Verified in Linux with 2001060411 build
Verified in MacOS with 20010600408 build
Status: RESOLVED → VERIFIED
Keywords: vtrunk

Comment 5

18 years ago
Verified using commercial trunk builds
2001061504 -win nt 4.0
2001061508 -linux 2.2, red hat 7.0
2001061508 -mac os 9.0.4

Removing keyword vtrunk
Keywords: vtrunk
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.