The default bug view has changed. See this FAQ.

Hide mozAudioContext behind a pref

RESOLVED FIXED in mozilla18

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Seems like there are people who test for mozAudioContext for forward compatibility (which is a sane thing to do), and we are breaking them!  We need to fix that.

Boris, is the right thing to do here returning null from AudioContext::Construct?  How can I make sure that tests for the existence of mozAudioContext would fail as well?
The right thing to do is probably to wait until I fix bug 778044 (which should be very shortly), and then make use of that.
Depends on: 778044
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 2

5 years ago
Created attachment 659372 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #659372 - Flags: review?(bzbarsky)
Comment on attachment 659372 [details] [diff] [review]
Patch (v1)

r=me, though if we're going to pref this off why not drop the "moz" from the name?
Attachment #659372 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 659372 [details] [diff] [review]
> Patch (v1)
> 
> r=me, though if we're going to pref this off why not drop the "moz" from the
> name?

The Web Audio spec is not stable yet, and also we're probably not going to implement all of the spec initially, so I would prefer us to keep this prefixed until we are sure that the API won't change and our implementation matches the spec.
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/898df3138008
Flags: in-testsuite+
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/898df3138008
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.