788310 - Hide mozAudioContext behind a pref

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Seems like there are people who test for mozAudioContext for forward compatibility (which is a sane thing to do), and we are breaking them!  We need to fix that.

Boris, is the right thing to do here returning null from AudioContext::Construct?  How can I make sure that tests for the existence of mozAudioContext would fail as well?

Comment 1

[Boris Zbarsky [:bzbarsky]]

The right thing to do is probably to wait until I fix bug 778044 (which should be very shortly), and then make use of that.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 659372 [details] [diff] [review]
Patch (v1)

r=me, though if we're going to pref this off why not drop the "moz" from the name?

Comment 4

[(no longer active)]

(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 659372 [details] [diff] [review]
> Patch (v1)
> 
> r=me, though if we're going to pref this off why not drop the "moz" from the
> name?

The Web Audio spec is not stable yet, and also we're probably not going to implement all of the spec initially, so I would prefer us to keep this prefixed until we are sure that the API won't change and our implementation matches the spec.

Comment 5

[(no longer active)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/898df3138008

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/898df3138008