Last Comment Bug 788310 - Hide mozAudioContext behind a pref
: Hide mozAudioContext behind a pref
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla18
Assigned To: :Ehsan Akhgari
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 778044
Blocks: webaudio
  Show dependency treegraph
 
Reported: 2012-09-04 14:59 PDT by :Ehsan Akhgari
Modified: 2012-09-08 18:11 PDT (History)
6 users (show)
ehsan: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (5.67 KB, patch)
2012-09-07 15:14 PDT, :Ehsan Akhgari
bzbarsky: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-09-04 14:59:48 PDT
Seems like there are people who test for mozAudioContext for forward compatibility (which is a sane thing to do), and we are breaking them!  We need to fix that.

Boris, is the right thing to do here returning null from AudioContext::Construct?  How can I make sure that tests for the existence of mozAudioContext would fail as well?
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2012-09-04 18:05:22 PDT
The right thing to do is probably to wait until I fix bug 778044 (which should be very shortly), and then make use of that.
Comment 2 :Ehsan Akhgari 2012-09-07 15:14:09 PDT
Created attachment 659372 [details] [diff] [review]
Patch (v1)
Comment 3 Boris Zbarsky [:bz] (still a bit busy) 2012-09-07 18:37:21 PDT
Comment on attachment 659372 [details] [diff] [review]
Patch (v1)

r=me, though if we're going to pref this off why not drop the "moz" from the name?
Comment 4 :Ehsan Akhgari 2012-09-08 11:17:59 PDT
(In reply to Boris Zbarsky (:bz) from comment #3)
> Comment on attachment 659372 [details] [diff] [review]
> Patch (v1)
> 
> r=me, though if we're going to pref this off why not drop the "moz" from the
> name?

The Web Audio spec is not stable yet, and also we're probably not going to implement all of the spec initially, so I would prefer us to keep this prefixed until we are sure that the API won't change and our implementation matches the spec.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-09-08 18:11:57 PDT
https://hg.mozilla.org/mozilla-central/rev/898df3138008

Note You need to log in before you can comment on or make changes to this bug.