Closed Bug 788310 Opened 7 years ago Closed 7 years ago
Audio Context behind a pref
Seems like there are people who test for mozAudioContext for forward compatibility (which is a sane thing to do), and we are breaking them! We need to fix that. Boris, is the right thing to do here returning null from AudioContext::Construct? How can I make sure that tests for the existence of mozAudioContext would fail as well?
The right thing to do is probably to wait until I fix bug 778044 (which should be very shortly), and then make use of that.
Depends on: 778044
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #659372 - Flags: review?(bzbarsky)
Comment on attachment 659372 [details] [diff] [review] Patch (v1) r=me, though if we're going to pref this off why not drop the "moz" from the name?
Attachment #659372 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky (:bz) from comment #3) > Comment on attachment 659372 [details] [diff] [review] > Patch (v1) > > r=me, though if we're going to pref this off why not drop the "moz" from the > name? The Web Audio spec is not stable yet, and also we're probably not going to implement all of the spec initially, so I would prefer us to keep this prefixed until we are sure that the API won't change and our implementation matches the spec.
Target Milestone: --- → mozilla18
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.