Fix the built-in error console and expose it in the app bar

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Trunk
All
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [completed-elm])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 658295 [details] [diff] [review]
patch

I wanted to see the error console while doing some testing on Metro.  I noticed that Metro has a built-in button to display the desktop error console in a separate window, but it didn't work on the tablet.  The old XUL Fennec console is still there, but it was accidentally broken by bug 747789 which changed a variable from "ConsoleView" to "ConsolePanelView" without changing all the references.

This patch fixes that, and exposes the built-in console panel in the app bar when devtools.errorconsole.enabled is true.
Attachment #658295 - Flags: review?(fryn)

Comment 1

6 years ago
Using Fennec as product is somewhat misleading.
We have been using Firefox as the product and Windows 8 Metro as the platform for Windows 8 Metro bugs.

I'll review this soon. :)
Component: General → General
Product: Fennec → Firefox
(Assignee)

Comment 2

6 years ago
Created attachment 659275 [details] [diff] [review]
patch v2

I accidentally reversed the logic for when to show the JS shell button.
Attachment #658295 - Attachment is obsolete: true
Attachment #659275 - Flags: review?(fryn)
Attachment #658295 - Flags: review?(fryn)

Updated

6 years ago
Attachment #659275 - Flags: review?(fryn) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/projects/elm/rev/76eae491f55a
Whiteboard: [completed-elm]

Updated

6 years ago
Component: General → General
Product: Firefox → Firefox for Metro
(Assignee)

Updated

6 years ago
Blocks: 801204
(Assignee)

Comment 4

6 years ago
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.