Closed Bug 788362 Opened 8 years ago Closed 8 years ago

9,440 bytes in 107 blocks are definitely lost as detected by Valgrind with selectforgc

Categories

(Core :: JavaScript Engine, defect, critical)

x86_64
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: gkw, Assigned: billm)

References

Details

(Keywords: regression, testcase, valgrind, Whiteboard: [fuzzblocker])

Attachments

(2 files)

Attached file Valgrind stack
selectforgc(Object)

causes Valgrind to show lots of leaks in 64-bit js opt shell on m-c changeset 7c75cd38626a with the following command:

valgrind --leak-check=full ./js testcase.js

I'm on Ubuntu Linux 12.04 with Valgrind SVN build r12957.
Setting [fuzzblocker] because this throws up all sorts of signatures (at least > 10 different ones).
Whiteboard: [fuzzblocker]
This bug blocks all leak fuzzing through Valgrind.

There's just too many signatures.
selectforgc was added in https://hg.mozilla.org/mozilla-central/rev/a0a7af840b83 through bug 742570.

Bill, possible for you to look at this?
Blocks: 742570
Keywords: regression
Assignee: general → wmccloskey
Attached patch patchSplinter Review
This caused us to mark Object during the last GC, so a bunch of stuff wasn't collected.
Attachment #661413 - Flags: review?(jcoppeard)
Comment on attachment 661413 [details] [diff] [review]
patch

Looks good!
Attachment #661413 - Flags: review?(jcoppeard) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/22bc2202fd8f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.