788430 - Minor bug in error handling of MozillaMaintenance Service

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[gliuwr]

there are minor bug in `workmonitor.cpp`,
that can crash the `maintenanceservice.exe`.
just try run `sc start MozillaMaintenance null software-update test` in your cmd,
then you can see there is a Application Error in Event Viewer.

Comment 1

[gliuwr]

Attachment: workmonitor.patch

Comment 2

[Dietrich Ayala (:dietrich)]

Rob, Dave, who can look at this patch?

Comment 3

[Dave Townsend [:mossop]]

I think ehsan or bbondy have some experience here

Comment 4

[gliuwr]

look here,
"We can only update update.status if argv[1] exists. " was written in comments.
hope this can help you to review.

Comment 5

[Brian R. Bondy [:bbondy]]

Comment on attachment 658410 [details] [diff] [review]
workmonitor.patch

Review of attachment 658410 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7810fee7ee9

Thanks for the patch! One request - to make life easier for those checking in your behalf, please make sure that your future patches include the necessary metadata needed for checkin. Thanks again!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f7810fee7ee9