Minor bug in error handling of MozillaMaintenance Service

RESOLVED FIXED in mozilla18

Status

()

Toolkit
Application Update
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gliuwr, Assigned: gliuwr)

Tracking

({crash})

unspecified
mozilla18
Other
Other
crash
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
there are minor bug in `workmonitor.cpp`,
that can crash the `maintenanceservice.exe`.
just try run `sc start MozillaMaintenance null software-update test` in your cmd,
then you can see there is a Application Error in Event Viewer.
(Assignee)

Comment 1

5 years ago
Created attachment 658410 [details] [diff] [review]
workmonitor.patch
(Assignee)

Updated

5 years ago
Keywords: crash
(Assignee)

Updated

5 years ago
Attachment #658410 - Flags: review?(dietrich)

Updated

5 years ago
Component: Installer → Application Update
Product: Firefox → Toolkit
Rob, Dave, who can look at this patch?
Attachment #658410 - Flags: review?(dietrich)
I think ehsan or bbondy have some experience here
(Assignee)

Comment 4

5 years ago
look here,
"We can only update update.status if argv[1] exists. " was written in comments.
hope this can help you to review.
blocking-basecamp: --- → ?
(Assignee)

Updated

5 years ago
blocking-basecamp: ? → ---
Attachment #658410 - Flags: review?(netzen)
Comment on attachment 658410 [details] [diff] [review]
workmonitor.patch

Review of attachment 658410 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!
Attachment #658410 - Flags: review?(netzen) → review+
Summary: the minor bug in workmonitor.cpp → Minor bug in error handling of Mozilla MaintenanceService
Summary: Minor bug in error handling of Mozilla MaintenanceService → Minor bug in error handling of MozillaMaintenance Service
Assignee: nobody → gliuwr
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7810fee7ee9

Thanks for the patch! One request - to make life easier for those checking in your behalf, please make sure that your future patches include the necessary metadata needed for checkin. Thanks again!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f7810fee7ee9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.