Last Comment Bug 788430 - Minor bug in error handling of MozillaMaintenance Service
: Minor bug in error handling of MozillaMaintenance Service
Status: RESOLVED FIXED
: crash
Product: Toolkit
Classification: Components
Component: Application Update (show other bugs)
: unspecified
: Other Other
: -- major (vote)
: mozilla18
Assigned To: gliuwr
:
: Robert Strong [:rstrong] (use needinfo to contact me)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-05 01:46 PDT by gliuwr
Modified: 2012-09-07 08:48 PDT (History)
7 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
workmonitor.patch (888 bytes, patch)
2012-09-05 01:47 PDT, gliuwr
netzen: review+
Details | Diff | Splinter Review

Description gliuwr 2012-09-05 01:46:05 PDT
there are minor bug in `workmonitor.cpp`,
that can crash the `maintenanceservice.exe`.
just try run `sc start MozillaMaintenance null software-update test` in your cmd,
then you can see there is a Application Error in Event Viewer.
Comment 1 gliuwr 2012-09-05 01:47:08 PDT
Created attachment 658410 [details] [diff] [review]
workmonitor.patch
Comment 2 Dietrich Ayala (:dietrich) 2012-09-05 09:17:55 PDT
Rob, Dave, who can look at this patch?
Comment 3 Dave Townsend [:mossop] 2012-09-05 09:24:39 PDT
I think ehsan or bbondy have some experience here
Comment 4 gliuwr 2012-09-05 09:34:26 PDT
look here,
"We can only update update.status if argv[1] exists. " was written in comments.
hope this can help you to review.
Comment 5 Brian R. Bondy [:bbondy] 2012-09-06 08:41:01 PDT
Comment on attachment 658410 [details] [diff] [review]
workmonitor.patch

Review of attachment 658410 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-09-06 16:50:54 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7810fee7ee9

Thanks for the patch! One request - to make life easier for those checking in your behalf, please make sure that your future patches include the necessary metadata needed for checkin. Thanks again!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Comment 7 Ed Morley [:emorley] 2012-09-07 08:48:35 PDT
https://hg.mozilla.org/mozilla-central/rev/f7810fee7ee9

Note You need to log in before you can comment on or make changes to this bug.