Closed Bug 788438 Opened 7 years ago Closed 2 years ago

Typo in test proxy/testDirectProxyValidateProperty6.js

Categories

(Core :: JavaScript Engine, defect)

18 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: bruant.d, Assigned: dvabhinav31)

Details

(Whiteboard: [js:p3])

Attachments

(1 file)

Incriminated test: 
https://hg.mozilla.org/mozilla-central/file/05adc6145143/js/src/jit-test/tests/proxy/testDirectProxyValidateProperty6.js
Line 11, there is a an "i" at the end of line. I think it has no impact on the test. It just resolves to "undefined" and the test continues as it would without the "i".
Whiteboard: [js:p3]
Assignee: general → nobody
Can't we just remove "i"?
I am a newbie. I would like to work on this bug.
(In reply to dvabhinav31@gmail.com from comment #2)
> I am a newbie. I would like to work on this bug.

Great! I assigned it to you.

You might be interested in https://wiki.mozilla.org/JavaScript:New_to_SpiderMonkey
Assignee: nobody → dvabhinav31
Status: NEW → ASSIGNED
I have encountered a problem while creating a patch.

while doing the command
 hg log -pr .

the error was

abort: no repository found in '/home/abhinav/src/mozilla-central' (.hg not found)!.
How do i FIX IT
Attached patch Bug-788438.patchSplinter Review
I have removed "i" as directed.
Attachment #8939053 - Flags: review?(bruant.d)
Attachment #8939053 - Flags: review+
Aaaaah!
i don't know how to make a review on Bugzilla!!!
i think i did fine?

Asking a review to someone who's review will be more meaningful than mine
Flags: needinfo?(jdemooij)
Attachment #8939053 - Flags: review?(bruant.d)
This is fine I think.
Flags: needinfo?(jdemooij)
Keywords: checkin-needed
I an new here and I am not able to understand what is going on. Is the bug done?? Or is there anything else to be done ?? Plz help.TIA
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df5abacfb68c
Remove extra i from testDirectProxyValidateProperty6.js. r=dbruant
Keywords: checkin-needed
Couldnt understand what pulsebot said. Can anyone please explain???
https://hg.mozilla.org/mozilla-central/rev/df5abacfb68c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.