Closed Bug 788440 Opened 7 years ago Closed 7 years ago

B2G Contact: Permission denied to access property 'id'

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: allstars.chh, Assigned: gwagner)

Details

(Whiteboard: [WebAPI:P2])

Attachments

(1 file, 1 obsolete file)

After apply the patch from Bug 788377,
when doing 'Import SIM Contacts' from Contacts app,
I can see errors from the log

E/GeckoConsole( 1566): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "Permission denied to access property 'id'" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]' when calling method: [nsIDOMContact::id]" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]
E/GeckoConsole( 1534): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "Permission denied to access property 'id'" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]' when calling method: [nsIDOMContact::id]" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]
Ok the readonly flags don't work here and contacts import from SIM card is currently broken.
blocking-basecamp: --- → ?
Assignee: nobody → anygregor
Attached patch patch (obsolete) — Splinter Review
Attachment #658564 - Flags: review?(bobbyholley+bmo)
Comment on attachment 658564 [details] [diff] [review]
patch

I don't understand the contact API well enough to judge if it's appropriate for content to be mucking with this. But if you say so.
Attachment #658564 - Flags: review?(bobbyholley+bmo) → review+
Importing SIM card contacts is a required feature for v1.
blocking-basecamp: ? → +
Whiteboard: [WebAPI:P2]
Since it's already r+ and Bug 788377 is already landed
Also I noticed Gwagner is taking PTO.
I'll help to push this patch
Attached patch Hg patchSplinter Review
convert to hg format.
Add r=bholley
Attachment #658564 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/3f5ae86f86f7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.