788440 - B2G Contact: Permission denied to access property 'id'

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

After apply the patch from Bug 788377,
when doing 'Import SIM Contacts' from Contacts app,
I can see errors from the log

E/GeckoConsole( 1566): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "Permission denied to access property 'id'" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]' when calling method: [nsIDOMContact::id]" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]
E/GeckoConsole( 1534): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "Permission denied to access property 'id'" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]' when calling method: [nsIDOMContact::id]" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 501}]

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In http://mxr.mozilla.org/mozilla-central/source/dom/contacts/ContactManager.js#386
it will new Contact,
is it okay to do it here?
Thanks

Comment 2

[Gregor Wagner [:gwagner]]

Ok the readonly flags don't work here and contacts import from SIM card is currently broken.

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 658564 [details] [diff] [review]
patch

I don't understand the contact API well enough to judge if it's appropriate for content to be mucking with this. But if you say so.

Comment 5

[Andrew Overholt [:overholt]]

Importing SIM card contacts is a required feature for v1.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Since it's already r+ and Bug 788377 is already landed
Also I noticed Gwagner is taking PTO.
I'll help to push this patch

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Hg patch

convert to hg format.
Add r=bholley

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f5ae86f86f7

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3f5ae86f86f7