788465 - Reload icon from Linux system icon theme is inappropriate for AwesomeBar

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Stephan Sokolow]

One of the implicit considerations for choosing an icon from a user-customizable theme must be its intended context. However, the "reload" icon Firefox hass been using in the AwesomeBar since somewhere around Firefox 9 or Firefox 10 is designed with the assumption that it will be used in *toolbar* buttons.

That means that, in many system icon themes (including the Elementary theme Lubuntu uses by default), it looks ill-fitted and out-of-place compared to the bundled reload icon used in Windows. (Typically, because toolbar icons are expected to be more detailed, more colourful, and colour-coordinated to match a background color other than white)

As, to the best of my knowledge, the system icon theme does not generally contain an icon for this context, I suggest reverting to the bundled single-color icon but resolving it via the theming system's facility for custom lookup paths to preserve the ability for it to be overridden.

Comment 1

[Stephan Sokolow]

I almost forgot to mention... using application-specific adjustments to the GTK+ icon-resolution functions to make application-specific icons themable is explained here:
https://live.gnome.org/ThemableAppSpecificIcons

Comment 2

[:Gijs (he/him)]

We package our own icon for this now, so resolving WFM. :-)