Closed
Bug 788486
Opened 12 years ago
Closed 12 years ago
GCLI rollup bug fix for bugs 786317, 739947, 708984, 786658, 681623, 787712
Categories
(DevTools :: Console, defect, P2)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
Attachments
(1 file, 1 obsolete file)
|
34.45 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 1•12 years ago
|
||
a.k.a https://github.com/campd/gcli/pull/59
Assignee: nobody → jwalker
Attachment #658482 -
Flags: review?(dcamp)
|
|
Assignee | |
Comment 2•12 years ago
|
||
I think I omitted a qref before uploading.
Attachment #658482 -
Attachment is obsolete: true
Attachment #658482 -
Flags: review?(dcamp)
Attachment #658521 -
Flags: review?(dcamp)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 658521 [details] [diff] [review] v2 Review of attachment 658521 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/commandline/gcli.jsm @@ +9450,2 @@ > this.onInputChange({ inputState: input }); > }; Do you mean to avoid calling onInputChange if value === newStr? Otherwise I don't quite understand why you're avoiding the assignment in that case, and a comment might help.
Attachment #658521 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b02fbf6363d7 https://tbpl.mozilla.org/?tree=Try&rev=2042d268a26b
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=aaa9837d68b3
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c606437fca80
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•