GCLI rollup bug fix for bugs 786317, 739947, 708984, 786658, 681623, 787712

RESOLVED FIXED in Firefox 18

Status

()

Firefox
Developer Tools: Console
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 18
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Priority: -- → P2
Target Milestone: --- → Firefox 18
Created attachment 658482 [details] [diff] [review]
v1

a.k.a https://github.com/campd/gcli/pull/59
Assignee: nobody → jwalker
Attachment #658482 - Flags: review?(dcamp)
Created attachment 658521 [details] [diff] [review]
v2

I think I omitted a qref before uploading.
Attachment #658482 - Attachment is obsolete: true
Attachment #658482 - Flags: review?(dcamp)
Attachment #658521 - Flags: review?(dcamp)

Comment 3

6 years ago
Comment on attachment 658521 [details] [diff] [review]
v2

Review of attachment 658521 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/commandline/gcli.jsm
@@ +9450,2 @@
>    this.onInputChange({ inputState: input });
>  };

Do you mean to avoid calling onInputChange if value === newStr?  Otherwise I don't quite understand why you're avoiding the assignment in that case, and a comment might help.
Attachment #658521 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/c606437fca80
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.