Closed Bug 788584 Opened 8 years ago Closed 7 years ago

TabsProgressListener.onLocationChange should obey the LOCATION_CHANGE_SAME_DOCUMENT flag rather than null-checking aRequest

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 22

People

(Reporter: jaws, Assigned: dao)

References

Details

Attachments

(1 file)

Bug 311007 added a flag, LOCATION_CHANGE_SAME_DOCUMENT, to OnLocationChange to state whether the location change is within the document.

The patch for bug 743421 tried to check for same document navigation by checking for a non-null aRequest. This should have checked LOCATION_CHANGE_SAME_DOCUMENT.

The change should be made in browser/base/content/browser.js.
Depends on: 839516
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #715635 - Flags: review?(jAwS)
No longer blocks: click-to-play
No longer depends on: 839516
Summary: Check LOCATION_CHANGE_SAME_DOCUMENT to determine if same-document navigation has occurred for click-to-play state → TabsProgressListener.onLocationChange should obey the LOCATION_CHANGE_SAME_DOCUMENT flag rather than null-checking aRequest
Attachment #715635 - Flags: review?(jAwS) → review+
https://hg.mozilla.org/mozilla-central/rev/cc8e0ae5459d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.