788588 - Device Storage - Default location for device storage on windows should be NS_WIN_PERSONAL_DIR

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Doug Turner (:dougt)]

Currently device storage on windows can't return any results because windows doesn't support a 'pictures', 'video', or 'music' directory.  On Windows, we can set the default location to the 'personal' directory which does contain these sorts of files on windows.

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 3

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/627f6297acea

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out for orange

https://hg.mozilla.org/mozilla-central/rev/fd4d9c386f97

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to Doug Turner (:dougt) from comment #1)
> Currently device storage on windows can't return any results because windows
> doesn't support a 'pictures', 'video', or 'music' directory.  On Windows, we
> can set the default location to the 'personal' directory which does contain
> these sorts of files on windows.
On Vista or later, You can get those folders using SHGetKnownFolderPath.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb762188%28v=vs.85%29.aspx

Comment 6

[Masatoshi Kimura [:emk]]

Oh, even SHGetFolderPath has CSIDL_MYMUSIC, CSIDL_MYPICTURES, and CSIDL_MYVIDEO.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb762494%28v=vs.85%29.aspx
So we can support 'pictures', 'video', or 'music' folders on all supported versions of Windows.

Comment 7

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd952fc4507b

Comment 8

[Doug Turner (:dougt)]

masatoshi, that would work too!  Do you want to do the plumbing for this?

Comment 9

[Masatoshi Kimura [:emk]]

(In reply to Doug Turner (:dougt) from comment #8)
> masatoshi, that would work too!  Do you want to do the plumbing for this?
I have no build environment at hand right now. If you are in a great hurry (this bug was fixed only seven hours), please do it yourself. Otherwise, I'll take it.

One correction: CSIDL_MYVIDEO was not supported on WinXP. So we will need a fallback for "video".

Comment 10

[Masatoshi Kimura [:emk]]

Ah, I misread the meaning of the shell version. CSIDL_MYVIDEO is supported on WinXP. Sorry for the spamming.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb776779%28v=vs.85%29.aspx

Comment 11

[Doug Turner (:dougt)]

no rush.  this isn't going to be turned on on windows desktop for a while.  Maybe the best approach is to file a follow up (bug 788924)

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cd952fc4507b