Closed
Bug 788588
Opened 11 years ago
Closed 11 years ago
Device Storage - Default location for device storage on windows should be NS_WIN_PERSONAL_DIR
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
Tracking | Status | |
---|---|---|
firefox18 | --- | fixed |
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(1 file)
2.32 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Currently device storage on windows can't return any results because windows doesn't support a 'pictures', 'video', or 'music' directory. On Windows, we can set the default location to the 'personal' directory which does contain these sorts of files on windows.
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #658543 -
Flags: review?(blassey.bugs)
Updated•11 years ago
|
Attachment #658543 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/627f6297acea
Backed out for orange https://hg.mozilla.org/mozilla-central/rev/fd4d9c386f97
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•11 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #1) > Currently device storage on windows can't return any results because windows > doesn't support a 'pictures', 'video', or 'music' directory. On Windows, we > can set the default location to the 'personal' directory which does contain > these sorts of files on windows. On Vista or later, You can get those folders using SHGetKnownFolderPath. http://msdn.microsoft.com/en-us/library/windows/desktop/bb762188%28v=vs.85%29.aspx
Comment 6•11 years ago
|
||
Oh, even SHGetFolderPath has CSIDL_MYMUSIC, CSIDL_MYPICTURES, and CSIDL_MYVIDEO. http://msdn.microsoft.com/en-us/library/windows/desktop/bb762494%28v=vs.85%29.aspx So we can support 'pictures', 'video', or 'music' folders on all supported versions of Windows.
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd952fc4507b
Assignee | ||
Comment 8•11 years ago
|
||
masatoshi, that would work too! Do you want to do the plumbing for this?
Comment 9•11 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #8) > masatoshi, that would work too! Do you want to do the plumbing for this? I have no build environment at hand right now. If you are in a great hurry (this bug was fixed only seven hours), please do it yourself. Otherwise, I'll take it. One correction: CSIDL_MYVIDEO was not supported on WinXP. So we will need a fallback for "video".
Comment 10•11 years ago
|
||
Ah, I misread the meaning of the shell version. CSIDL_MYVIDEO is supported on WinXP. Sorry for the spamming. http://msdn.microsoft.com/en-us/library/windows/desktop/bb776779%28v=vs.85%29.aspx
Assignee | ||
Comment 11•11 years ago
|
||
no rush. this isn't going to be turned on on windows desktop for a while. Maybe the best approach is to file a follow up (bug 788924)
Comment 12•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd952fc4507b
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•