Closed Bug 788588 Opened 7 years ago Closed 7 years ago

Device Storage - Default location for device storage on windows should be NS_WIN_PERSONAL_DIR

Categories

(Core :: DOM: Device Interfaces, defect)

All
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
Tracking Status
firefox18 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file)

No description provided.
Currently device storage on windows can't return any results because windows doesn't support a 'pictures', 'video', or 'music' directory.  On Windows, we can set the default location to the 'personal' directory which does contain these sorts of files on windows.
Attached patch patch v.1Splinter Review
Attachment #658543 - Flags: review?(blassey.bugs)
Attachment #658543 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/627f6297acea
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Backed out for orange

https://hg.mozilla.org/mozilla-central/rev/fd4d9c386f97
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Doug Turner (:dougt) from comment #1)
> Currently device storage on windows can't return any results because windows
> doesn't support a 'pictures', 'video', or 'music' directory.  On Windows, we
> can set the default location to the 'personal' directory which does contain
> these sorts of files on windows.
On Vista or later, You can get those folders using SHGetKnownFolderPath.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb762188%28v=vs.85%29.aspx
Oh, even SHGetFolderPath has CSIDL_MYMUSIC, CSIDL_MYPICTURES, and CSIDL_MYVIDEO.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb762494%28v=vs.85%29.aspx
So we can support 'pictures', 'video', or 'music' folders on all supported versions of Windows.
masatoshi, that would work too!  Do you want to do the plumbing for this?
(In reply to Doug Turner (:dougt) from comment #8)
> masatoshi, that would work too!  Do you want to do the plumbing for this?
I have no build environment at hand right now. If you are in a great hurry (this bug was fixed only seven hours), please do it yourself. Otherwise, I'll take it.

One correction: CSIDL_MYVIDEO was not supported on WinXP. So we will need a fallback for "video".
Ah, I misread the meaning of the shell version. CSIDL_MYVIDEO is supported on WinXP. Sorry for the spamming.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb776779%28v=vs.85%29.aspx
Blocks: 788924
no rush.  this isn't going to be turned on on windows desktop for a while.  Maybe the best approach is to file a follow up (bug 788924)
https://hg.mozilla.org/mozilla-central/rev/cd952fc4507b
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.