788603 - [B2G] all mochitests using bidi_numeral_test.js fail in OOP mode

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Griffin (:jgriffin)]

All of the layout tests which use the file tests/layout/base/tests/bidi_numeral_test.js are failing when run in B2G because they're not OOP-compatible.  They set prefs directly (http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/bidi_numeral_test.js#42) instead of using SpecialPowers.

These tests will be disabled for B2G runs until they can be updated.  The approximate list is here:  http://mxr.mozilla.org/mozilla-central/search?string=bidi_numeral_test.js

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It seems simpler to just fix the test, no?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: fix easy-to-fix uses of enablePrivilege in layout/base/tests/

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec21394970c

What needs to happen to get these un-disabled?

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to David Baron [:dbaron] from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec21394970c
> 
> What needs to happen to get these un-disabled?

I'll take care of it once I see this hit m-c.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ec21394970c

Comment 6

[Jonathan Griffin (:jgriffin)]

Affected tests have been re-enabled for b2g.  Thanks for the fix!