788828 - Allow moztest to take in a computed result and infer the expected & actual results

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: $SUBJECT

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 658656 [details] [diff] [review]
$SUBJECT

Review of attachment 658656 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: moztest/moztest/results.py
@@ +160,5 @@
> +            self.result = result
> +        elif result in self.POSSIBLE_RESULTS:
> +            self._result_actual = result
> +            self.result = self.calculate_result(self._result_expected,
> +                                            self._result_actual)

You should check for self.POSSIBLE_RESULTS before self.COMPUTED_RESULTS, otherwise you won't correctly handle unexpected successes for the case where you call __init__('FAIL') and finish('PASS').  You can then remove the check for 'PASS' and 'ERROR' in infer_results() (since for the latter, the default expected result is 'PASS' anyway).

Comment 3

[Jonathan Griffin (:jgriffin)]

https://github.com/mozilla/mozbase/commit/a5f76f09bf367df9da277e8c9c0ad02ff457c8f8

Comment 4

[Jonathan Griffin (:jgriffin)]

Some changes needed still; I pushed prematurely.

Comment 5

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: last minute fixes

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 659291 [details] [diff] [review]
last minute fixes

Review of attachment 659291 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the quick fix!

Comment 7

[Mihnea Dobrescu-Balaur (:mihneadb)]

https://github.com/mozilla/mozbase/commit/30a2b278430e0ab9946e0e93197b3f8ded8c634a