Closed Bug 788884 Opened 8 years ago Closed 8 years ago
Browser App .cpp: Compiler warning about different signs in comparison
gcc 4.7 warns about signs in a comparison. > make: Entering directory `/home/tdz/Projects/mozilla/build/mozilla-central/b2g/app' > /home/tdz/Projects/mozilla/src/mozilla-central/b2g/app/nsBrowserApp.cpp: In function 'int main(int, char**)': > /home/tdz/Projects/mozilla/src/mozilla-central/b2g/app/nsBrowserApp.cpp:167:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Attachment #658689 - Flags: review?(benjamin)
Comment on attachment 658689 [details] [diff] [review] Patch for fixing the warning + a potential integer underflow A cast would be fine here; we aren't dealing with untrusted input, but this works.
Attachment #658689 - Flags: review?(benjamin) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.