Closed
Bug 788884
Opened 13 years ago
Closed 13 years ago
nsBrowserApp.cpp: Compiler warning about different signs in comparison
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tzimmermann, Assigned: tzimmermann)
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
gcc 4.7 warns about signs in a comparison.
> make[6]: Entering directory `/home/tdz/Projects/mozilla/build/mozilla-central/b2g/app'
> /home/tdz/Projects/mozilla/src/mozilla-central/b2g/app/nsBrowserApp.cpp: In function 'int main(int, char**)':
> /home/tdz/Projects/mozilla/src/mozilla-central/b2g/app/nsBrowserApp.cpp:167:78: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → tdz
|
|
Assignee | |
Updated•13 years ago
|
Attachment #658689 -
Flags: review?(benjamin)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 658689 [details] [diff] [review]
Patch for fixing the warning + a potential integer underflow
A cast would be fine here; we aren't dealing with untrusted input, but this works.
Attachment #658689 -
Flags: review?(benjamin) → review+
|
||
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•