78900 - Offline - Download now command needs to pass nsMsgWindow to backend

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[David :Bienvenu]

The js function onOfflineFolderDownload needs to pass an nsMsgWindow to the 
downloadAllForOffline method, so that the user can see progress, and stop the
command. A progress window would be best, probably; another possibility would be
to close the property dialog and use the parent window. (In the latter scenario,
the property dialog would need to be closed because it is modal to the parent
window, and the user can't press stop on the parent window when it has a modal
window open on top of it). Not sure what the spec says, but my guess is that it
calls for a progress window.

Comment 1

[jglick]

This is in the the Folder Properties dialog, Offline tab, when the "Download 
Now" button is clicked, correct?

Agree a progress dialog would be best. User clicks "Download Now", Folder 
properties dialog remains open and a progress window opens on top. Progress 
dialog shows status of download and allows user to stop download.  Progress 
dialog goes away when complete. 

Comment 2

[Diane Sun]

Reassign to mohanb

Comment 3

[grylchan]

changing qa from Esther to myself

Comment 4

[scottputterman]

nominating nsbeta1

Comment 5

[Mohan Bhamidipati]

Attachment: proposed patch (adding msgwindow support)

Comment 6

[Jussi-Pekka Mantere]

PDT+ per 6/12 mtg.

Comment 7

[Mohan Bhamidipati]

Attachment: proposed patch v1

Comment 8

[David :Bienvenu]

cool, this will do until we get a real progress window from mscott sr=bienvenu

Comment 9

[Mohan Bhamidipati]

cc'ing bhuvan for r=;

Comment 10

[selmer (gone)]

You need the r= before you can get the a=, has Bhuvan responded yet?

Comment 11

[racham]

r=bhuvan.

Comment 12

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.2.
(on behalf of drivers)

Comment 13

[Christopher Blizzard (:blizzard)]

This is a 0.9.2 bug.  What's the status on getting this checked in?

Comment 14

[Asa Dotzler [:asa]]

pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)

Comment 15

[Jussi-Pekka Mantere]

Removing PDT+, marking nsbranch; should be checked into the 0.9.3 trunk ASAP,
tested & verified, then submitted for limbo builds.

Comment 16

[Diane Sun]

Fix checked in on behalf on mohanb

Comment 17

[Jussi-Pekka Mantere]

Adding vtrunk; bugs need to be verified in the trunk for eventual limbo checkins.

Comment 18

[Jussi-Pekka Mantere]

Clearing resolution, nsBranch bugs should be closed only after checkins into
limbo builds.

Comment 19

[grylchan]

Commercial builds
2001-07-05-09-trunk/ win nt 4.0
2001-07-05-08-trunk/ linux 2.2, red hat 7.0
2001-07-05-08-trunk/ mac os 9.0.4

Right click on a folder, choose properties, click
the offline tab, and click the 'download now' button
results in the following:
  - at the bottom of the Messenger window frame(where
    the icons reside) this appears:
      - <folder name>: receiving message x of x 
      - progress bar appears
    Both the bar and message count get updated until the
    downloading is done.
  - messages are downloaded

Verified on trunk.

Removing Keyword Vtrunk.

adding 'verified on trunk' to status whiteboard.

Leaving status as Assigned per instructions from Jussi.

Comment 20

[Blake Ross]

Missed 0.9.3.

Comment 21

[Mohan Bhamidipati]

changing the resolution to fixed, 
since it is checked into the trunk;

Comment 22

[grylchan]

Commercial builds:
2001-08-15-09-trunk/ - nt 4.0
2001-08-15-14-trunk- linux 2.2, mac 9.0.4

Right click on a folder, choose properties, click
the offline tab, and click the 'download now' button
results in the following:
  - at the bottom of the Messenger window frame(where
    the icons reside) this appears:
      - <folder name>: receiving message x of x 
      - progress bar appears
    Both the bar and message count get updated until the
    downloading is done.
  - messages are downloaded

Marking as verified.