789042 - Allow for multi-banner upload in app admin

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: Social Integration, defect, P3)

Description

[Chelsea Novak [:chelsea]]

It would be splendid if I could upload banners in batches rather than one by one.

Comment 1

[Osmose [:osmose, :mkelly]]

After working on this for a bit, I believe I have a working patch. I ran into the same issues we ran into on the mothership with regards to having multiple locales available:

- The banners presented to the user are only those available in their active locale.
- When they create a banner, the locale they were using when it was saved is also saved.
- If the user switches locales, the banner images of their current banners WON'T change.
- If we update the image for a specific locale, the banner images for users WILL change.
- Locales should work as you expect: Using the "es" locale will match es-LA, es-ES, etc.

- The admin interface has changed to be pretty much identical to how mothership banners are created: there is a list of locales below the banner info, and you can add more locales to the list and save them all at once: http://cl.ly/image/0P3c2V3D182n
- The screenshot above also shows that the image and thumbnail fields for the banner are still present; they are the default image and thumbnail used when a locale doesn't have a custom image and should usually be en-US.

I'll write up some docs on how to add new images and banners to help switching over to this new layout. 

Next time we push I'll spend a bit of time consolidating banners so that we don't have a banner for each locale like we do now. I checked the production database, and we only have a handful of non-en-US banners that will need to be moved, so the porting shouldn't be very difficult.

Comment 2

[[github robot]]

Commits pushed to develop at https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/1648e039c5c07ba5df3b76226dff102ccc85eb32
Allow upload of multiple banner images at once.

Changes the FacebookBanner admin to work more like
the mothership BannerInstance admin and allow for custom banner
images for each locale a FacebookBanner is available in. 
FacebookBannerInstances now store which locale they were created
in.

bug 789042

https://github.com/mozilla/affiliates/commit/0b272023971239a20ab086606a408ee4464aa767
Add tests for multi-banner upload changes.

fix bug 789042

Comment 3

[Rebecca Billings [:rbillings]]

I didn't test the admin at all last time. Please add a link & verification steps for adding banners or mark as [qa-], thanks.

Comment 4

[Osmose [:osmose, :mkelly]]

Marking as [qa-].

chelsea: Can you verify that the new interface on dev or stage is suitable?

Comment 5

[Chelsea Novak [:chelsea]]

I can't get to https://affiliates-fb-dev.allizom.org/admin to test. Am I going to the right place still or did that change when we changed when we added ldap to the admin?

Comment 6

[Osmose [:osmose, :mkelly]]

affiliates-fb-dev has been decommissioned, we're back to using https://affiliates-dev.allizom.org/admin for testing.

Comment 7

[Chelsea Novak [:chelsea]]

Looks great. Do you want me to upload some banners as a test?

Comment 8

[Osmose [:osmose, :mkelly]]

Yes please!

Comment 9

[Chelsea Novak [:chelsea]]

Works beautifully!