Closed Bug 789050 Opened 12 years ago Closed 11 years ago

Replace any nspr types with stdint types in winrt code

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: completed-elm)

Attachments

(1 file)

These were ditched on mc via bug 579517.

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int32_t
convert PRUintn uint32_t
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
Blocks: metro-widget
Attached patch patchSplinter Review
Assignee: nobody → jmathies
Comment on attachment 679124 [details] [diff] [review]
patch

easy review, the patch is a simple search and replace. This builds locally just fine.
Attachment #679124 - Flags: review?(netzen)
Comment on attachment 679124 [details] [diff] [review]
patch

Review of attachment 679124 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/winrt/FrameworkView.cpp
@@ +240,5 @@
>      return;
>    Rect msrect;
>    mWindow->get_Bounds(&msrect);
> +  nsIntRect mozrect(0, 0, (uint32_t)ceil(msrect.Width),
> +                 (uint32_t)ceil(msrect.Height));

I've fixed this spacing locally.
Comment on attachment 679124 [details] [diff] [review]
patch

Review of attachment 679124 [details] [diff] [review]:
-----------------------------------------------------------------

:D
Attachment #679124 - Flags: review?(netzen) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: