789067 - Camera - clean up code and remove ICameraControl.h

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

dom/camera/ICameraControl.h was originally introduced to resolve a circular dependency.  It has since been pointed out to me that this can be solved in a simpler way.  No functional change is intended, just easier-to-maintain code.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: remove ICameraControl.h, refactor, stitch everything back up

Hey :bent, cleaning this up was originally your idea--any chance you have time for a review?

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

:bent, review ping?

Comment 3

[Kai-Chih Hu [:khu]]

Bent, could you help to review this one? Thank you.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sorry, this is in my review queue, but it's much lower priority than some of the other stuff in there. I'll get to it as soon as I can.

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Hey :bent, how's your schedule looking these days?

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 662347 [details] [diff] [review]
remove ICameraControl.h, refactor, stitch everything back up

Stealing review from bent who is overwhelmed by his review queue right now. This looks good to me, but I realize it's been long enough here that there's a good chance this doesn't apply any more. If it does not, I'd gladly re-review and updated patch, assuming updating it isn't trivial in which case you should feel free to just land the updated patch.

Comment 7

[BMO Automation]

Firefox OS is not being worked on