Closed
Bug 789067
Opened 12 years ago
Closed 6 years ago
Camera - clean up code and remove ICameraControl.h
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mikeh, Assigned: mikeh)
Details
Attachments
(1 file)
16.28 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
dom/camera/ICameraControl.h was originally introduced to resolve a circular dependency. It has since been pointed out to me that this can be solved in a simpler way. No functional change is intended, just easier-to-maintain code.
Assignee | ||
Comment 1•12 years ago
|
||
Hey :bent, cleaning this up was originally your idea--any chance you have time for a review?
Attachment #662347 -
Flags: review?(bent.mozilla)
Assignee | ||
Comment 2•12 years ago
|
||
:bent, review ping?
Comment 3•12 years ago
|
||
Bent, could you help to review this one? Thank you.
Sorry, this is in my review queue, but it's much lower priority than some of the other stuff in there. I'll get to it as soon as I can.
Assignee | ||
Comment 5•12 years ago
|
||
Hey :bent, how's your schedule looking these days?
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Comment 6•11 years ago
|
||
Comment on attachment 662347 [details] [diff] [review] remove ICameraControl.h, refactor, stitch everything back up Stealing review from bent who is overwhelmed by his review queue right now. This looks good to me, but I realize it's been long enough here that there's a good chance this doesn't apply any more. If it does not, I'd gladly re-review and updated patch, assuming updating it isn't trivial in which case you should feel free to just land the updated patch.
Attachment #662347 -
Flags: review?(bent.mozilla) → review+
Comment 7•6 years ago
|
||
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•