78923 - prefs: Offline should be a child of "Mail and Newsgroups", not a child of the root

Status: VERIFIED INVALID

(SeaMonkey :: MailNews: Backend, defect)

Description

[(not reading, please use [e-mail] instead)]

offline tabs in prefs is top level, should be under "Mail and Newsgroups"

In prefs, we've got:

...
Composer
Mail And Newsgroups
  Message Display
  ...
Offline
...

It should be:

...
Composer
Mail And Newsgroups
  Message Display
  Offline
...

Comment 1

[sairuh (rarely reading bugmail)]

agreed. also, Offline as a parent category has an unecessary twisty.

Comment 2

[Diane Sun]

reassign to mohanb

Comment 3

[Håkan Waara]

Taking, I have a fix coming up...

Comment 4

[Håkan Waara]

Attachment: fix. -uN to show cvs add-ed and cvs remove-d files

Comment 5

[timeless]

I don't think this bug is about file movement.  Unless the module owners ask 
for it.  This should have been a simple 10 line change.

If you see other problems either file bugs for them or at least mention that 
you found them in the bug and that you propose to fix them.

Comment 6

[Håkan Waara]

timeless: Other childs of the MailNews tab in preferences have their files in 
the mailnews module, so to be consistent (and consistency is always good) we 
should also have this in the mailnews module.

all: some unrelated changes to imapFolderProps.xul slipped in. sorry! I will 
attach a better patch.

Comment 7

[Håkan Waara]

Attachment: better patch

Comment 8

[Keyser Sose]

r=ksosez on second patch.

Comment 9

[(not reading, please use [e-mail] instead)]

oops, this bug is invalid.

looking at http://www.mozilla.org/mailnews/specs/offline/#Prefs, the offline 
item is in the right spot.  and, 4.x had it at the top level too.

there are non mailnews offline prefs (ex: "start up mode")

marking invalid.  sorry to waste your time, hwaara.

Comment 10

[Håkan Waara]

*sigh*. verifying