78931 - [RFE] MAPI addressbook support for the Mozilla Addressbook

Status: VERIFIED FIXED

(MailNews Core :: LDAP Integration, enhancement, P1)

Description

[Cuchulainn]

There is currently no support for dynamically including MAPI addressbooks in a
windows environment in the mozilla addressbook.

Comment 1

[Keyser Sose]

marking NEW.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

The patch for this is in the parent, bug 78933.  However, that entire patch
doesn't need review here.  From an earlier mail from Martin, the pieces of that
patch that need review for this bug to be satisfied are the following new files.

addrbook/src/nsMapiAddressBook.cpp 
addrbook/src/nsMapiAddressBook.h
addrbook/src/nsAbOutlookDirFactory.cpp  
addrbook/src/nsAbOutlookDirFactory.h    
addrbook/src/nsAbOutlookDirectory.cpp   
addrbook/src/nsAbOutlookDirectory.h     
addrbook/src/nsAbOutlookCard.cpp        
addrbook/src/nsAbOutlookCard.h  

Scott, do you know anyone with some MAPI expertise that could look at this piece?

Comment 3

[scottputterman]

rhp was probably the best person, but he's not available to do this anymore. 
Candice might be able to.  mscott might have had some experience when working
with rhp on the AB api's in 4.5 but I'm not sure if he had to actually look at MAPI.

Comment 4

[chuang]

I looked at the code briefly,  it looks good.  Though I don't know about MAPI
but it looks really similar to the import code for Outlook.

In nsAbOutlookCard.cpp (line 48) and nsAbOutlookDirectory.cpp (line 85) for
"delete mMapiData ;"  Can you put a null checking before calling the delete?

if (mMapiData)
  delete mMapiData ;

Comment 5

[chuang]

And initialize mMapiData to nsnull in the constructor.

Comment 6

[John Marmion]

I have updated the patch file with those changes. See the latest file for
#78933.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Reassigning bugs related to LDAP/MAPI addressbook change landing to John
Marmion, as he'll be driving this landing going forward.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

2nd try at reassignment.

Comment 9

[John Marmion]

Updated the patch file attached to #78933:

Updated the license boilerplate for all new source files submitted with this
patch. I have also updated the experimental builds at
<http://abzilla.mozdev.org> with this patch against today's head for Linux,
Windows and the Mac. 

Comment 10

[Blake Ross]

Missed 0.9.3.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Code checked in.

Comment 12

[yulian chang]

Verified with 20010815 trunk build

Comment 13

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.