Closed Bug 78931 Opened 24 years ago Closed 23 years ago

[RFE] MAPI addressbook support for the Mozilla Addressbook

Categories

(MailNews Core :: LDAP Integration, enhancement, P1)

enhancement

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.4

People

(Reporter: martin.maher, Assigned: john.marmion)

References

Details

There is currently no support for dynamically including MAPI addressbooks in a
windows environment in the mozilla addressbook.
Blocks: 78933
marking NEW.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Adding MAPI addressbook support to the Mozilla Addressbook → [RFE] MAPI addressbook support for the Mozilla Addressbook
Severity: enhancement → major
Status: NEW → ASSIGNED
OS: Windows NT → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla0.9.1
Target Milestone: mozilla0.9.1 → mozilla0.9.2
The patch for this is in the parent, bug 78933.  However, that entire patch
doesn't need review here.  From an earlier mail from Martin, the pieces of that
patch that need review for this bug to be satisfied are the following new files.

addrbook/src/nsMapiAddressBook.cpp 
addrbook/src/nsMapiAddressBook.h
addrbook/src/nsAbOutlookDirFactory.cpp  
addrbook/src/nsAbOutlookDirFactory.h    
addrbook/src/nsAbOutlookDirectory.cpp   
addrbook/src/nsAbOutlookDirectory.h     
addrbook/src/nsAbOutlookCard.cpp        
addrbook/src/nsAbOutlookCard.h  

Scott, do you know anyone with some MAPI expertise that could look at this piece?
rhp was probably the best person, but he's not available to do this anymore. 
Candice might be able to.  mscott might have had some experience when working
with rhp on the AB api's in 4.5 but I'm not sure if he had to actually look at MAPI.
I looked at the code briefly,  it looks good.  Though I don't know about MAPI
but it looks really similar to the import code for Outlook.

In nsAbOutlookCard.cpp (line 48) and nsAbOutlookDirectory.cpp (line 85) for
"delete mMapiData ;"  Can you put a null checking before calling the delete?

if (mMapiData)
  delete mMapiData ;
And initialize mMapiData to nsnull in the constructor.

I have updated the patch file with those changes. See the latest file for
#78933.
Reassigning bugs related to LDAP/MAPI addressbook change landing to John
Marmion, as he'll be driving this landing going forward.
Assignee: dmose → srilatha
Status: ASSIGNED → NEW
Component: Address Book → LDAP Mail/News Integration
QA Contact: esther → yulian
2nd try at reassignment.
Assignee: srilatha → john.marmion
Updated the patch file attached to #78933:

Updated the license boilerplate for all new source files submitted with this
patch. I have also updated the experimental builds at
<http://abzilla.mozdev.org> with this patch against today's head for Linux,
Windows and the Mac. 
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Missed 0.9.3.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Code checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified with 20010815 trunk build
Status: RESOLVED → VERIFIED
[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.
Severity: major → enhancement
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.