Created attachment 659051 [details] [diff] [review] patch This button works with mouse clicks but not with taps. Simple fix.
Attachment #659051 - Flags: review?(mark.finkle)
Attachment #659051 - Flags: review?(mark.finkle) → review+
Whiteboard: [metro-preview] → [metro-preview][completed-elm]
Jared implemented the onkeypress and onmousedown in bug 778340 for better responsiveness, but when we fixed mouse/tap events, that approach of course no longer worked for touch. I'm okay with leaving it as it is now. :)
Could we have left my approach, added a oncommand handler, and had the onmousedown and onkeydown handlers call preventDefault?
(In reply to Jared Wein [:jaws] from comment #3) > Could we have left my approach, added a oncommand handler, and had the > onmousedown and onkeydown handlers call preventDefault? That sounds good; I can try that out next week (or I'm happy to review a patch).
Component: Toolbars → General
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch. Sorry for the bugspam. Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.