789341 - Webapps.js catch eats everything

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: Patch

MANIFEST_PARSE_ERROR is a JSON parsing error, so it should be better to put only JSON.parse in the try block.

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 659055 [details] [diff] [review]
Patch

Review of attachment 659055 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/src/Webapps.js
@@ +106,1 @@
>            Services.DOMRequest.fireError(request, "MANIFEST_PARSE_ERROR");

You need to return at this point, to not run the code that follows.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch v2

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=b5de07d07bc2

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca36ddcde6b1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca36ddcde6b1