789388 - Breakpad revision link needs updating/doesn't go to the changeset

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

This is on prod and staging, so not a very-recent regression

STR:

1. Load https://crash-stats-dev.allizom.org/status
2. Click on the link for "Breakpad revision", e.g. http://code.google.com/p/google-breakpad/source/browse/?r=1024

Expected Results:

Shows the revision #'s changes on Google Code

Actual Results:

Link should probably go to http://code.google.com/p/google-breakpad/source/detail?r=1024

Comment 1

[Laura Thomson :laura]

This is fine, goes to the revision rather than the log as intended.

Comment 2

[Peter Bengtsson [:peterbe]]

Already got started 
https://github.com/mozilla/socorro/pull/1423

Comment 3

[Peter Bengtsson [:peterbe]]

It was so easy and I already got started. 
:laura r?  on the PR

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3145548d8a0c68c71e2ab1ba39e5b2ec00b5676f
fixes bug 789388 - Breakpad revision link go to the changeset, r=AdrianGaudebert

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Need to reopen -- it's now going to:

http://code.google.com/p/google-breakpad/source/detail?r=CURRENT_BREAKPAD_REVISION

Not sure why it's not getting that set?

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

This is a dev only problem, because dev is running the new, configmanized middleware, and that one doesn't know how to get breakpad revisions. See bug 901504.

Comment 7

[Matt Brandt [:mbrandt]]

Bumping to resolved, dependent bug 901504 has been resolved.

Comment 8

[Matt Brandt [:mbrandt]]

QA verified on dev - the revision url on the /status/ page correctly redirects to github as well as the current commit. Happy times