789605 - Some customers getting dozens of "TypeError: self.addonWorker is null" exceptions with 1Password enabled

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Mike]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/536.26.13 (KHTML, like Gecko) Version/6.0.1 Safari/536.26.13

Steps to reproduce:

Just turning on the 1Password extension (JetPack-based) in Firefox


Actual results:

While everything looks fine with 1Password in Firefox, some users reported getting dozens of the following messages in their console:

Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: error: An exception occurred.
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: Traceback (most recent call last):
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: File "resource://onepassword-at-agilebits-dot-com/api-utils/lib/timer.js", line 28, in notify
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: callback.apply(null, args);
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: File "resource://onepassword-at-agilebits-dot-com/api-utils/lib/content/w...", line 97, in
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: self.emit.apply(self, JSON.parse(args));
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: File "resource://onepassword-at-agilebits-dot-com/api-utils/lib/events.js", line 119, in emit
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: return this.emitOnObject.apply(this, args);
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: File "resource://onepassword-at-agilebits-dot-com/api-utils/lib/events.js", line 149, in emitOnObject
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: listener.apply(targetObj, params);
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: File "resource://onepassword-at-agilebits-dot-com/api-utils/lib/content/w...", line 205, in portEmit
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: self.addonWorker.onContentScriptEvent.apply(self.addonWorker, arguments);
Sep 7 14:18:58 Michaels-iMac [0x0-0x43b43b].org.mozilla.firefox[17833]: TypeError: self.addonWorker is null


Expected results:

Nothing. 

We provided the user with the RC version 1.10 SDK version and confirmed that it stopped several messages from showing up. According to the customer, the "document.location is null" is the one that stopped showing up.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Hi Mike,

I'm not able to reproduce this errors / warnings with 1password addon on my machine. Could you please give little more details on what's the version of FF is used. If there is any specific pages visiting which causes these errors, or if there are any other addons installed (which could cause some conflicts ?).

Or if it's possible to provide reduced snippet of code to reproduce that would be very helpful.

You mention also mention that "document.location is null" errors
stopped in 1.10 RC, although I don't see there messages in your snippet above, so
I'm little confused.

Either way some more info helping to reproduce this would be very helpful.

Thanks

Comment 2

[Michael Schmitt]

A user replies:
 
Firefox 15.0.1 on OS X 10.6.8 and 10.7.4.
 
I can recreate problem with a new FF profile, no other add-ons except 1Password, all other plug-ins disabled.

The mention of "document.location is null" errors meant that using the released version of 1Password (pre 1.10 RC), there were a large number of those errors thrown, in addition to the self.addonWorker is null error posted.  The document.location errors appear to be fixed by 1.10 RC.

For reproducing, I see the error in the console System Log during normal Firefox activity, but it is difficult to pin it down to a specific action.  One thing I've found is if I do the following steps, it is likely to throw the exception:

1. Open Firefox.
2. Go to https://www.icloud.com
    Note that I'm not signed in, so icloud displays the sign-on dialog.
3. Quit Firefox.

Note that I have an entry for iCloud in my 1Password keychain.  Thus I'm suspecting that the exception has something to do with 1Password checking the login in this URL page; it may be that it doesn't happen when I go to pages for which I have no 1Password entry.

Let me know if there is some kind of log I could create that would narrow it down.

Comment 4

[Michael Schmitt]

Bug 792223 was marked as a duplicate, but it contains the solution to the problem?

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Michael Schmitt from comment #4)
> Bug 792223 was marked as a duplicate, but it contains the solution to the
> problem?

Yep. Just making sure we only have a single bug on file for this issue.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/586

Pointer to Github pull-request

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 663245 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/586

I'd prefer fixing the underlyng issue where content script is styll alive after having being destroyed. But that's a reasonable fix in the meantime. Thanks Erik.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d7e117c9ddc3cecdd1ed9b06fc5667be15991819
Bug 789605 self._addonWorker is null error

https://github.com/mozilla/addon-sdk/commit/b3cbdfee465792c0ca130459421a229459cfadf3
Merge pull request #586 from erikvold/789605

Bug 789605 self._addonWorker is null error r=@ochameau

Comment 9

[Michael Schmitt]

Which Firefox release is targeted?