789674 - Update about:support to use Troubleshoot.jsm

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

about:support should be updated to use the snapshot data from Troubleshoot.jsm.

This patch also adds a "Copy raw data to clipboard" button and keeps the current copy button but renames it "Copy text to clipboard".

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 659454 [details] [diff] [review]
patch

Review of attachment 659454 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.js
@@ +212,3 @@
>  }
>  
> +function copyRawDataToClipboard(button) {

are the "if (button)" checks necessary? and what could fail in this function to require a try catch?

::: toolkit/locales/en-US/chrome/global/aboutSupport.dtd
@@ +59,5 @@
>  
>  <!ENTITY aboutSupport.installationHistoryTitle "Installation History">
>  <!ENTITY aboutSupport.updateHistoryTitle "Update History">
>  
> +<!ENTITY aboutSupport.copyToClipboard.label "Copy text to clipboard">

need to change entity name due to string change

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Obs.: I'm assuming the addition of the new button was discussed with support and they want to have both buttons there

Comment 3

[Drew Willcoxon :adw]

(In reply to :Felipe Gomes from comment #1)
> > +function copyRawDataToClipboard(button) {
> 
> are the "if (button)" checks necessary?

The function could conceivably be called without passing in a button.

> and what could fail in this function to require a try catch?

Probably nothing, but a failure shouldn't cause the button to remain disabled.

(In reply to :Felipe Gomes from comment #2)
> Obs.: I'm assuming the addition of the new button was discussed with support
> and they want to have both buttons there

I didn't discuss the buttons with them, and nobody's responded to all the recent updates to bug 554174.

Comment 4

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83925e071235

Comment 5

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/83925e071235

Comment 6

[[e-mail]]

Comment on attachment 659454 [details] [diff] [review]
patch

>+        return strings.formatStringFromName(nameOrMsg, msgArray,
>+                                            msgArray.length);
There's an assertion that fires when there are no format string...