Closed Bug 789847 Opened 7 years ago Closed 7 years ago
Remove the usage of PR
_CALLBACK from our tree
See <http://mxr.mozilla.org/mozilla-central/ident?i=PR_CALLBACK>. PR_CALLBACK expands to nothing, and is useless. We should just remove it. Note that the patch here should not touch the NSPR or NSS code, bit we can remove PR_CALLBACK from everywhere else in the tree.
Try run for df744b8ca6c2 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=df744b8ca6c2 Results (out of 6 total builds): exception: 6 Builds (or logs if builds failed) available at: http://email@example.com
I modified a script similar to attachment 653946 [details] to remove PR_CALLBACK without touching the NSPR or NSS code as specified; this patch is the result of the script (will attach separately). I also manually maintained code formatting where appropriate.
I caught an additional formatting issue a result of the patch. Also, on extra try submissions (all cancelled in a few minutes): * First one: An empty try that was a mistake. * Second one: I'm not sure if it matters, but I thought I should probably get a review first on the patch before sending to try anyway.
I goofed again, this is the correct attachment.
Try run for 994431c0baab is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=994431c0baab Results (out of 6 total builds): exception: 6 Builds (or logs if builds failed) available at: http://firstname.lastname@example.org
My mistake, I should've double-checked MXR before posting my patch. My script was missing PR_CALLBACKs at the end of lines, this patch should now cover all usage of PR_CALLBACKs in the tree, excluding NSPR and NSS code.
I also should've made sure my patch message isn't a try command. It's really up for review now, I'm not touching it anymore! ;-)
It looks like a green try for my patch: https://tbpl.mozilla.org/?tree=Try&rev=4281a1110e36
Comment on attachment 664539 [details] [diff] [review] Remove PR_CALLBACK from tree Looks great, thanks!
Attachment #664539 - Flags: review?(ehsan) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.