Remove the usage of PR_CALLBACK from our tree

RESOLVED FIXED in mozilla18

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Away for a while, Assigned: isaac)

Tracking

(Blocks: 1 bug)

Trunk
mozilla18
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=ehsan][lang=c++])

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

5 years ago
See <http://mxr.mozilla.org/mozilla-central/ident?i=PR_CALLBACK>.  PR_CALLBACK expands to nothing, and is useless.  We should just remove it.

Note that the patch here should not touch the NSPR or NSS code, bit we can remove PR_CALLBACK from everywhere else in the tree.
(Assignee)

Updated

5 years ago
Assignee: nobody → isaac.aggrey

Comment 1

5 years ago
Try run for df744b8ca6c2 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=df744b8ca6c2
Results (out of 6 total builds):
    exception: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/isaac.aggrey@gmail.com-df744b8ca6c2
(Assignee)

Comment 2

5 years ago
Created attachment 664320 [details] [diff] [review]
Remove PR_CALLBACK from tree

I modified a script similar to attachment 653946 [details] to remove PR_CALLBACK without touching the NSPR or NSS code as specified; this patch is the result of the script (will attach separately).

I also manually maintained code formatting where appropriate.
Attachment #664320 - Flags: review?(ehsan)
(Assignee)

Comment 3

5 years ago
Created attachment 664322 [details] [diff] [review]
Remove PR_CALLBACK from tree (correct formatting)

I caught an additional formatting issue a result of the patch.

Also, on extra try submissions (all cancelled in a few minutes):
* First one: An empty try that was a mistake.
* Second one: I'm not sure if it matters, but I thought I should probably get a review first on the patch before sending to try anyway.
Attachment #664320 - Attachment is obsolete: true
Attachment #664320 - Flags: review?(ehsan)
Attachment #664322 - Flags: review?(ehsan)
(Assignee)

Comment 4

5 years ago
Created attachment 664323 [details] [diff] [review]
Remove PR_CALLBACK from tree (correct formatting)

I goofed again, this is the correct attachment.
Attachment #664322 - Attachment is obsolete: true
Attachment #664322 - Flags: review?(ehsan)
Attachment #664323 - Flags: review?(ehsan)

Comment 5

5 years ago
Try run for 994431c0baab is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=994431c0baab
Results (out of 6 total builds):
    exception: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/isaac.aggrey@gmail.com-994431c0baab
(Assignee)

Comment 6

5 years ago
Created attachment 664331 [details] [diff] [review]
Remove PR_CALLBACK from tree

My mistake, I should've double-checked MXR before posting my patch.

My script was missing PR_CALLBACKs at the end of lines, this patch should now cover all usage of PR_CALLBACKs in the tree, excluding NSPR and NSS code.
Attachment #664323 - Attachment is obsolete: true
Attachment #664323 - Flags: review?(ehsan)
Attachment #664331 - Flags: review?(ehsan)
(Assignee)

Comment 7

5 years ago
Created attachment 664334 [details]
Script to remove PR_CALLBACK
(Assignee)

Comment 8

5 years ago
Created attachment 664539 [details] [diff] [review]
Remove PR_CALLBACK from tree

I also should've made sure my patch message isn't a try command. It's really up for review now, I'm not touching it anymore! ;-)
Attachment #664331 - Attachment is obsolete: true
Attachment #664331 - Flags: review?(ehsan)
Attachment #664539 - Flags: review?(ehsan)
(Assignee)

Comment 9

5 years ago
It looks like a green try for my patch: https://tbpl.mozilla.org/?tree=Try&rev=4281a1110e36
(Reporter)

Comment 10

5 years ago
Comment on attachment 664539 [details] [diff] [review]
Remove PR_CALLBACK from tree

Looks great, thanks!
Attachment #664539 - Flags: review?(ehsan) → review+
(Reporter)

Comment 11

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b13571ca268d
https://hg.mozilla.org/mozilla-central/rev/b13571ca268d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(Reporter)

Updated

5 years ago
Blocks: 796941
You need to log in before you can comment on or make changes to this bug.