789856 - script errors not handled when script blocked by a Content Policy

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tanvi Vyas[:tanvi]]

When a Content Policy blocks a script, the error from the script is not handled with an error event that propogates to the client (and is hence displayed to the developer in the Error Console or Web Console).

I discovered this while trying to catch a script load error with the onerror event when a the mixed content Content Policy blocked the script.

I believe the error should be handled in CheckContentPolicy in nsScriptLoader.cpp:
mxr.mozilla.org/mozilla-central/source/content/base/src/nsScriptLoader.cpp#212

Comment 1

[Boris Zbarsky [:bzbarsky]]

So this is basically about us firing onerror on the script if the script is blocked by CheckLoadURI or content policy?

Jonas, any objections?  In particular, would this let sites detect when ad-blockers are in use in ways they can't right now?

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Boris Zbarsky (:bz) from comment #1)
> Jonas, any objections?  In particular, would this let sites detect when
> ad-blockers are in use in ways they can't right now?

I doubt that's possible: it's trivial to add a side-effect to a script and check whether that side-effect happened in a later script in the page.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I agree. It will always be possible to detect that a script is blocked, so being explicit about it seems ok.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fire error events on <script> elements which completely fail to start the load.

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 661587 [details] [diff] [review]
Fire error events on <script> elements which completely fail to start the load.

>+		test_bug789856.html \

This file is missing.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Now with the test file

Good catch!

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: And now actually passing tests, I hope....

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: And now actually passing tests, I hope....

Comment 9

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e61b7c193325

Comment 10

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/e61b7c193325